public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: linville@tuxdriver.com, yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] mac80211: disassociate when moving to new BSS
Date: Sun, 07 Sep 2008 00:26:39 +0200	[thread overview]
Message-ID: <1220739999.21016.8.camel@johannes.berg> (raw)
In-Reply-To: <1220739259-16918-3-git-send-email-tomas.winkler@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

On Sun, 2008-09-07 at 01:14 +0300, Tomas Winkler wrote:
> This patch cleans current association when leaving to new BSS. this is
> needed as old configuration and data were still stored in station table
> and in low level driver, causing problems (e.g. 11n mlme) in new BSS
> 
> Signed-off-by: Ron Rindjunsky <ron.rindjunsky@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  net/mac80211/mlme.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index ba255e2..aa5367e 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -3414,9 +3414,14 @@ void ieee80211_sta_req_auth(struct ieee80211_sub_if_data *sdata,
>  		return;
>  
>  	if ((ifsta->flags & (IEEE80211_STA_BSSID_SET |
> -				IEEE80211_STA_AUTO_BSSID_SEL)) &&
> +			     IEEE80211_STA_AUTO_BSSID_SEL)) &&
>  	    (ifsta->flags & (IEEE80211_STA_SSID_SET |
> -				IEEE80211_STA_AUTO_SSID_SEL))) {
> +			     IEEE80211_STA_AUTO_SSID_SEL))) {
> +
> +		if (ifsta->state == IEEE80211_STA_MLME_ASSOCIATED)
> +			ieee80211_set_disassoc(sdata, ifsta, 1, 1,
> +					       WLAN_REASON_DEAUTH_LEAVING);
> +
>  		set_bit(IEEE80211_STA_REQ_AUTH, &ifsta->request);
>  		queue_work(local->hw.workqueue, &ifsta->work);
>  	}

Looks sane to me

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2008-09-06 22:26 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-06 22:14 [RFC PATCH 0/3] mac80211 dissasociation Tomas Winkler
2008-09-06 22:14 ` [RFC PATCH 1/3] mac80211: restructure disassoc/deauth flows Tomas Winkler
2008-09-06 22:14   ` [RFC PATCH 2/3] mac80211: disassociate when moving to new BSS Tomas Winkler
2008-09-06 22:14     ` [RFC PATCH 3/3] mac80211: remove disassociation code from ieee80211_set_associated Tomas Winkler
2008-09-06 22:30       ` Johannes Berg
2008-09-06 22:33         ` Tomas Winkler
2008-09-06 22:26     ` Johannes Berg [this message]
2008-09-06 22:25   ` [RFC PATCH 1/3] mac80211: restructure disassoc/deauth flows Johannes Berg
2008-09-06 22:27     ` Johannes Berg
2008-09-06 22:32     ` Tomas Winkler
2008-09-06 22:42       ` Johannes Berg
2008-09-06 23:24         ` Tomas Winkler
2008-09-06 23:34           ` Johannes Berg
2008-09-08  8:23   ` Johannes Berg
2008-09-08  8:55     ` Tomas Winkler
2008-09-08  9:02       ` Johannes Berg
2008-09-07  1:08 ` [RFC PATCH 0/3] mac80211 dissasociation Marcel Holtmann
2008-09-07  5:41   ` Tomas Winkler
2008-09-07 13:39 ` Johannes Berg
2008-09-07 14:24   ` Tomas Winkler
2008-09-07 14:40     ` Johannes Berg
2008-09-07 14:50       ` Tomas Winkler
2008-09-07 23:14         ` Tomas Winkler
2008-09-08  7:44           ` Johannes Berg
2008-09-08  7:58           ` Johannes Berg
2008-09-08  8:18             ` Tomas Winkler
2008-09-08  8:30               ` Johannes Berg
2008-09-08  8:31                 ` Johannes Berg
2008-09-08  8:38           ` Johannes Berg
2008-09-08  8:46             ` Tomas Winkler
2008-09-08  8:58               ` Johannes Berg
2008-09-08  9:06                 ` Tomas Winkler
2008-09-08  9:11                   ` Johannes Berg
2008-09-08  9:24                   ` Johannes Berg
2008-09-08  9:32                     ` Tomas Winkler
2008-09-08  9:37                       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220739999.21016.8.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomas.winkler@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox