From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] mac80211: remove disassociation code from ieee80211_set_associated
Date: Sun, 7 Sep 2008 01:33:58 +0300 [thread overview]
Message-ID: <1ba2fa240809061533x4296448br11b326371d4fdb1f@mail.gmail.com> (raw)
In-Reply-To: <1220740231.21016.13.camel@johannes.berg>
On Sun, Sep 7, 2008 at 1:30 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Sun, 2008-09-07 at 01:14 +0300, Tomas Winkler wrote:
>
>> - ieee80211_led_assoc(local, assoc);
>> + ieee80211_led_assoc(local, 1);
>>
>> - sdata->bss_conf.assoc = assoc;
>> + sdata->bss_conf.assoc = 1;
>
> I think you should use "true" at least for the latter "1"
>
>> + sdata->bss_conf.assoc = 0;
>
> and "false" here, and if the LED interface uses "bool" then for that
> too.
>
> The actual patch looks good to me though.
Will do
Thanks
Tomas
next prev parent reply other threads:[~2008-09-06 22:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 22:14 [RFC PATCH 0/3] mac80211 dissasociation Tomas Winkler
2008-09-06 22:14 ` [RFC PATCH 1/3] mac80211: restructure disassoc/deauth flows Tomas Winkler
2008-09-06 22:14 ` [RFC PATCH 2/3] mac80211: disassociate when moving to new BSS Tomas Winkler
2008-09-06 22:14 ` [RFC PATCH 3/3] mac80211: remove disassociation code from ieee80211_set_associated Tomas Winkler
2008-09-06 22:30 ` Johannes Berg
2008-09-06 22:33 ` Tomas Winkler [this message]
2008-09-06 22:26 ` [RFC PATCH 2/3] mac80211: disassociate when moving to new BSS Johannes Berg
2008-09-06 22:25 ` [RFC PATCH 1/3] mac80211: restructure disassoc/deauth flows Johannes Berg
2008-09-06 22:27 ` Johannes Berg
2008-09-06 22:32 ` Tomas Winkler
2008-09-06 22:42 ` Johannes Berg
2008-09-06 23:24 ` Tomas Winkler
2008-09-06 23:34 ` Johannes Berg
2008-09-08 8:23 ` Johannes Berg
2008-09-08 8:55 ` Tomas Winkler
2008-09-08 9:02 ` Johannes Berg
2008-09-07 1:08 ` [RFC PATCH 0/3] mac80211 dissasociation Marcel Holtmann
2008-09-07 5:41 ` Tomas Winkler
2008-09-07 13:39 ` Johannes Berg
2008-09-07 14:24 ` Tomas Winkler
2008-09-07 14:40 ` Johannes Berg
2008-09-07 14:50 ` Tomas Winkler
2008-09-07 23:14 ` Tomas Winkler
2008-09-08 7:44 ` Johannes Berg
2008-09-08 7:58 ` Johannes Berg
2008-09-08 8:18 ` Tomas Winkler
2008-09-08 8:30 ` Johannes Berg
2008-09-08 8:31 ` Johannes Berg
2008-09-08 8:38 ` Johannes Berg
2008-09-08 8:46 ` Tomas Winkler
2008-09-08 8:58 ` Johannes Berg
2008-09-08 9:06 ` Tomas Winkler
2008-09-08 9:11 ` Johannes Berg
2008-09-08 9:24 ` Johannes Berg
2008-09-08 9:32 ` Tomas Winkler
2008-09-08 9:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240809061533x4296448br11b326371d4fdb1f@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox