From: Marcel Holtmann <holtmann@linux.intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net,
yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] mac80211 dissasociation
Date: Sun, 07 Sep 2008 03:08:44 +0200 [thread overview]
Message-ID: <1220749724.6714.128.camel@californication> (raw)
In-Reply-To: <1220739259-16918-1-git-send-email-tomas.winkler@intel.com>
Hi Tomas,
> This series should fix mac problems in disassociation
> There are two basic problems disassociation in current implementation.
> The order of steps in the dissociation flow and missing proper
> disassociation when moving from one AP to another.
it would be nice if you add the problem description into the commit
messages of the actual patches. This helps to actually figure out the
reason for these kind of changes and they are then stored together with
the patch. We really have to be more verbose why we are doing things. If
anyone has to go through one year old kernels and figure out why a
change has been made, they are basically lost. I had to go through 7
years old kernels in the past and every extra piece of information is so
useful then.
Regards
Marcel
next prev parent reply other threads:[~2008-09-07 1:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 22:14 [RFC PATCH 0/3] mac80211 dissasociation Tomas Winkler
2008-09-06 22:14 ` [RFC PATCH 1/3] mac80211: restructure disassoc/deauth flows Tomas Winkler
2008-09-06 22:14 ` [RFC PATCH 2/3] mac80211: disassociate when moving to new BSS Tomas Winkler
2008-09-06 22:14 ` [RFC PATCH 3/3] mac80211: remove disassociation code from ieee80211_set_associated Tomas Winkler
2008-09-06 22:30 ` Johannes Berg
2008-09-06 22:33 ` Tomas Winkler
2008-09-06 22:26 ` [RFC PATCH 2/3] mac80211: disassociate when moving to new BSS Johannes Berg
2008-09-06 22:25 ` [RFC PATCH 1/3] mac80211: restructure disassoc/deauth flows Johannes Berg
2008-09-06 22:27 ` Johannes Berg
2008-09-06 22:32 ` Tomas Winkler
2008-09-06 22:42 ` Johannes Berg
2008-09-06 23:24 ` Tomas Winkler
2008-09-06 23:34 ` Johannes Berg
2008-09-08 8:23 ` Johannes Berg
2008-09-08 8:55 ` Tomas Winkler
2008-09-08 9:02 ` Johannes Berg
2008-09-07 1:08 ` Marcel Holtmann [this message]
2008-09-07 5:41 ` [RFC PATCH 0/3] mac80211 dissasociation Tomas Winkler
2008-09-07 13:39 ` Johannes Berg
2008-09-07 14:24 ` Tomas Winkler
2008-09-07 14:40 ` Johannes Berg
2008-09-07 14:50 ` Tomas Winkler
2008-09-07 23:14 ` Tomas Winkler
2008-09-08 7:44 ` Johannes Berg
2008-09-08 7:58 ` Johannes Berg
2008-09-08 8:18 ` Tomas Winkler
2008-09-08 8:30 ` Johannes Berg
2008-09-08 8:31 ` Johannes Berg
2008-09-08 8:38 ` Johannes Berg
2008-09-08 8:46 ` Tomas Winkler
2008-09-08 8:58 ` Johannes Berg
2008-09-08 9:06 ` Tomas Winkler
2008-09-08 9:11 ` Johannes Berg
2008-09-08 9:24 ` Johannes Berg
2008-09-08 9:32 ` Tomas Winkler
2008-09-08 9:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220749724.6714.128.camel@californication \
--to=holtmann@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomas.winkler@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox