* [PATCH] iwl3945: remove bogus comment
@ 2008-10-29 0:02 Johannes Berg
2008-10-29 17:29 ` reinette chatre
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2008-10-29 0:02 UTC (permalink / raw)
To: John Linville; +Cc: Tomas Winkler, linux-wireless
I added this comment myself, but it's clearly wrong. I had meant
to place it in iwl_mac_add_interface, which at the time didn't
honour the MAC address setting, but it does now.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 2 --
1 file changed, 2 deletions(-)
--- everything.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2008-10-29 00:58:17.000000000 +0100
+++ everything/drivers/net/wireless/iwlwifi/iwl3945-base.c 2008-10-29 00:58:26.000000000 +0100
@@ -6742,8 +6742,6 @@ static int iwl3945_mac_config_interface(
return rc;
}
- /* XXX: this MUST use conf->mac_addr */
-
if (!iwl3945_is_alive(priv))
return -EAGAIN;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iwl3945: remove bogus comment
2008-10-29 0:02 [PATCH] iwl3945: remove bogus comment Johannes Berg
@ 2008-10-29 17:29 ` reinette chatre
0 siblings, 0 replies; 2+ messages in thread
From: reinette chatre @ 2008-10-29 17:29 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, Tomas Winkler, linux-wireless
On Tue, 2008-10-28 at 17:02 -0700, Johannes Berg wrote:
> I added this comment myself, but it's clearly wrong. I had meant
> to place it in iwl_mac_add_interface, which at the time didn't
> honour the MAC address setting, but it does now.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Thanks Johannes
ack
Reinette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-29 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-29 0:02 [PATCH] iwl3945: remove bogus comment Johannes Berg
2008-10-29 17:29 ` reinette chatre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox