public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Williams <dcbw@redhat.com>
Cc: Jouni Malinen <j@w1.fi>, Marcel Holtmann <marcel@holtmann.org>,
	linux-wireless@vger.kernel.org
Subject: Re: Missing link quality with wireless-testing
Date: Wed, 18 Feb 2009 15:25:44 +0100	[thread overview]
Message-ID: <1234967144.4023.25.camel@johannes.local> (raw)
In-Reply-To: <1234961297.13950.55.camel@localhost>

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

On Wed, 2009-02-18 at 07:48 -0500, Dan Williams wrote:

> > >   - max_qual.level == 0 (ie, dBm values)
> > 
> > That is an area where NM (= 0) and mac80211 (= -110) do not agree.
> 
> Then mac80211 is not conforming to WEXT...  unless it's setting
> IW_QUAL_DBM in the updated field, which it probably is.

Yeah, it is.

> Before we added IW_QUAL_DBM, the switch between dBm and RSSI was
> max_qual.level; if it was 0, level was in dBm, because no cards in use
> in Linux at that time could support a signal of more 0 dBm.  Thus, if it
> was over 0, the value was in RSSI.
> 
> Here's the relevant bit of wireless.h:
> 
>         /* Quality range (link, level, noise)
>          * If the quality is absolute, it will be in the range [0 ; max_qual],
>          * if the quality is dBm, it will be in the range [max_qual ; 0].
> 
> That doc never got updated for IW_QUAL_DBM either.

Fun. But what did I expect. I withdraw my earlier patch then.

> NM doesn't really handle IW_QUAL_DBM (added in WE-19).  Mainly because
> stuff worked without it, and it wasn't implemented in drivers until
> quite recently.  NM should handle IW_QUAL_DBM.

Does all that mean that we cannot actually get this working right now
without adding back qual.qual? Or should we just remove IW_QUAL_DBM?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2009-02-18 14:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17 18:52 Missing link quality with wireless-testing Marcel Holtmann
2009-02-17 19:43 ` Johannes Berg
2009-02-17 20:24   ` Marcel Holtmann
2009-02-17 20:55     ` Johannes Berg
2009-02-17 21:09       ` Marcel Holtmann
2009-02-17 23:25         ` Dan Williams
2009-02-18  4:57           ` Marcel Holtmann
2009-02-18  7:31             ` Jouni Malinen
2009-02-18  8:06               ` Marcel Holtmann
2009-02-18  8:25                 ` Jouni Malinen
2009-02-18 12:18                   ` Dan Williams
2009-02-18 12:33                     ` Jouni Malinen
2009-02-18 12:48                       ` Dan Williams
2009-02-18 13:20                         ` Dan Williams
2009-02-18 14:01                         ` Jouni Malinen
2009-02-18 14:25                         ` Johannes Berg [this message]
2009-02-18 13:37                     ` Johannes Berg
2009-02-18 15:13                       ` Dan Williams
2009-02-18 16:48                         ` Johannes Berg
2009-02-18 17:27 ` [PATCH] cfg80211/mac80211: fill qual.qual value/adjust max_qual.qual Johannes Berg
2009-02-18 17:29   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234967144.4023.25.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=dcbw@redhat.com \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox