From: Jouni Malinen <j@w1.fi>
To: Dan Williams <dcbw@redhat.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: Missing link quality with wireless-testing
Date: Wed, 18 Feb 2009 14:33:01 +0200 [thread overview]
Message-ID: <20090218123301.GA6152@jm.kir.nu> (raw)
In-Reply-To: <1234959523.13950.47.camel@localhost>
On Wed, Feb 18, 2009 at 07:18:43AM -0500, Dan Williams wrote:
> With WEXT, there are three ways to calculate pretty bars. They *all*
> require max_qual values returned from the GIWRANGE handler, because
> otherwise you have no f**king clue what the upper or lower bounds are.
> QUAL.LEVEL in dBm
> --------------
>
> Requires:
> - max_qual.level == 0 (ie, dBm values)
That is an area where NM (= 0) and mac80211 (= -110) do not agree.
> NM is probably fine here with qual == 0 because I doubt the GIWRANGE
> handler is returning a valid max_qual.qual > 0 anymore with Johannes'
> patch. Could be wrong though.
Well, it is not fine, but not only for that reason.. max_qual.qual is
still set to 100 and the IW_QUAL_QUAL_INVALID is not used for it.
However, even if I set IW_QUAL_QUAL_INVALID and remove "quality" from
wpa_supplicant dbus interface, I still get NM showing perfect 100%
signal all the time regardless of how close to losing the connection the
card really is..
I gave up on trying to understand all the cases, but my assumption is
that the remaining issue is in the disagreement on max_qua.level for the
dBm case. However, I'm not sure whether fixing that would automatically
resolve the issues with wext (it might be enough for the current nl80211
version with wpa_supplicant from git head).
> Ah right; the dbus interface shouldn't be appending "quality" to the
> dict if the driver doesn't provide valid quality (ie, max_qual.updated
> has the QUAL_INVALID bit set). Same thing for noise and level.
The unknown values are not included anymore in wpa_supplicant 0.7.x.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2009-02-18 12:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 18:52 Missing link quality with wireless-testing Marcel Holtmann
2009-02-17 19:43 ` Johannes Berg
2009-02-17 20:24 ` Marcel Holtmann
2009-02-17 20:55 ` Johannes Berg
2009-02-17 21:09 ` Marcel Holtmann
2009-02-17 23:25 ` Dan Williams
2009-02-18 4:57 ` Marcel Holtmann
2009-02-18 7:31 ` Jouni Malinen
2009-02-18 8:06 ` Marcel Holtmann
2009-02-18 8:25 ` Jouni Malinen
2009-02-18 12:18 ` Dan Williams
2009-02-18 12:33 ` Jouni Malinen [this message]
2009-02-18 12:48 ` Dan Williams
2009-02-18 13:20 ` Dan Williams
2009-02-18 14:01 ` Jouni Malinen
2009-02-18 14:25 ` Johannes Berg
2009-02-18 13:37 ` Johannes Berg
2009-02-18 15:13 ` Dan Williams
2009-02-18 16:48 ` Johannes Berg
2009-02-18 17:27 ` [PATCH] cfg80211/mac80211: fill qual.qual value/adjust max_qual.qual Johannes Berg
2009-02-18 17:29 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218123301.GA6152@jm.kir.nu \
--to=j@w1.fi \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox