* [PATCH] iwl3945: fix section type conflict on powerpc
@ 2009-04-22 15:33 Johannes Berg
2009-04-22 18:03 ` reinette chatre
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2009-04-22 15:33 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, Reinette Chatre
For some reason on powerpc I get:
drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
__ksymtab_iwl3945_rx_queue_reset causes a section type conflict
drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
__ksymtab_iwl3945_rx_queue_reset causes a section type conflict
The function doesn't need to be exported, and unexporting fixes it,
so I'm not thinking about what is causing it.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
1 file changed, 1 deletion(-)
--- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:53.614082341 +0200
+++ wireless-testing/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:55.382327490 +0200
@@ -1413,7 +1413,6 @@ void iwl3945_rx_queue_reset(struct iwl_p
rxq->free_count = 0;
spin_unlock_irqrestore(&rxq->lock, flags);
}
-EXPORT_SYMBOL(iwl3945_rx_queue_reset);
/*
* this should be called while priv->lock is locked
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iwl3945: fix section type conflict on powerpc
2009-04-22 15:33 [PATCH] iwl3945: fix section type conflict on powerpc Johannes Berg
@ 2009-04-22 18:03 ` reinette chatre
0 siblings, 0 replies; 2+ messages in thread
From: reinette chatre @ 2009-04-22 18:03 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, linux-wireless
On Wed, 2009-04-22 at 08:33 -0700, Johannes Berg wrote:
> For some reason on powerpc I get:
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>
> The function doesn't need to be exported, and unexporting fixes it,
> so I'm not thinking about what is causing it.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:53.614082341 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:55.382327490 +0200
> @@ -1413,7 +1413,6 @@ void iwl3945_rx_queue_reset(struct iwl_p
> rxq->free_count = 0;
> spin_unlock_irqrestore(&rxq->lock, flags);
> }
> -EXPORT_SYMBOL(iwl3945_rx_queue_reset);
>
> /*
> * this should be called while priv->lock is locked
>
>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Thank you
Reinette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-22 17:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-22 15:33 [PATCH] iwl3945: fix section type conflict on powerpc Johannes Berg
2009-04-22 18:03 ` reinette chatre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox