[PATCH] rfkill: remove input Kconfig

[PATCH] rfkill: remove input Kconfig

[Johannes Berg]

Now that we added the ioctl, there's no need to ask
the user to configure this. We will keept it enabled
for now, and eventually swap the default to n, maybe
let people configure it under EMBEDDED or so. In any
case, there's no need to bother users with this now.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/rfkill/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- wireless-testing.orig/net/rfkill/Kconfig	2009-06-07 19:37:34.000000000 +0200
+++ wireless-testing/net/rfkill/Kconfig	2009-06-07 19:37:41.000000000 +0200
@@ -18,7 +18,7 @@ config RFKILL_LEDS
 	default y
 
 config RFKILL_INPUT
-	bool "RF switch input support"
+	bool
 	depends on RFKILL
 	depends on INPUT = y || RFKILL = INPUT
-	default y if !EMBEDDED
+	default y

Re: [PATCH] rfkill: remove input Kconfig

[Marcel Holtmann]

Hi Johannes,

> Now that we added the ioctl, there's no need to ask
> the user to configure this. We will keept it enabled
> for now, and eventually swap the default to n, maybe
> let people configure it under EMBEDDED or so. In any
> case, there's no need to bother users with this now.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
>  net/rfkill/Kconfig |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- wireless-testing.orig/net/rfkill/Kconfig	2009-06-07 19:37:34.000000000 +0200
> +++ wireless-testing/net/rfkill/Kconfig	2009-06-07 19:37:41.000000000 +0200
> @@ -18,7 +18,7 @@ config RFKILL_LEDS
>  	default y
>  
>  config RFKILL_INPUT
> -	bool "RF switch input support"
> +	bool
>  	depends on RFKILL
>  	depends on INPUT = y || RFKILL = INPUT
> -	default y if !EMBEDDED
> +	default y

if you want this for normal setups, I totally agree that we not should
ask the user. However when in EMBEDDED, lets give them a chance to not
compile this in. Since most likely it is not needed at all.

Regards

Marcel

[PATCH v2] rfkill: remove input Kconfig

[Johannes Berg]

Now that we added the ioctl, there's no need to ask
the user to configure this. We will keep it enabled
for now, and eventually swap the default to n. Also
let embedded users select it only if they need it.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
v2: Turn default back to N for embedded, and make the question itself
    depend on embedded.

 net/rfkill/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- wireless-testing.orig/net/rfkill/Kconfig	2009-06-07 21:26:29.000000000 +0200
+++ wireless-testing/net/rfkill/Kconfig	2009-06-08 08:11:15.000000000 +0200
@@ -18,7 +18,7 @@ config RFKILL_LEDS
 	default y
 
 config RFKILL_INPUT
-	bool "RF switch input support"
+	bool "RF switch input support" if EMBEDDED
 	depends on RFKILL
 	depends on INPUT = y || RFKILL = INPUT
 	default y if !EMBEDDED