* [PATCH] iwlwifi: fix aggregation limit
@ 2009-07-01 12:57 Johannes Berg
2009-07-01 15:06 ` Marcel Holtmann
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2009-07-01 12:57 UTC (permalink / raw)
To: John Linville; +Cc: Reinette Chatre, linux-wireless
According to the documentation, the limit is 0x3f == 63, not 64.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
It seems bug 2018 is related to the link quality command, because it
seems I can trivially trigger it or similar bugs that way, but this
doesn't fix it.
--- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:33.804427206 +0200
+++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:38.924427592 +0200
@@ -1922,7 +1922,7 @@ struct iwl_link_qual_general_params {
#define LINK_QUAL_AGG_DISABLE_START_MIN (0)
#define LINK_QUAL_AGG_FRAME_LIMIT_DEF (31)
-#define LINK_QUAL_AGG_FRAME_LIMIT_MAX (64)
+#define LINK_QUAL_AGG_FRAME_LIMIT_MAX 0x3f
#define LINK_QUAL_AGG_FRAME_LIMIT_MIN (0)
/**
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iwlwifi: fix aggregation limit
2009-07-01 12:57 [PATCH] iwlwifi: fix aggregation limit Johannes Berg
@ 2009-07-01 15:06 ` Marcel Holtmann
2009-07-01 15:09 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Marcel Holtmann @ 2009-07-01 15:06 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, Reinette Chatre, linux-wireless
Hi Johannes,
> According to the documentation, the limit is 0x3f == 63, not 64.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> It seems bug 2018 is related to the link quality command, because it
> seems I can trivially trigger it or similar bugs that way, but this
> doesn't fix it.
>
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:33.804427206 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:38.924427592 +0200
> @@ -1922,7 +1922,7 @@ struct iwl_link_qual_general_params {
> #define LINK_QUAL_AGG_DISABLE_START_MIN (0)
>
> #define LINK_QUAL_AGG_FRAME_LIMIT_DEF (31)
> -#define LINK_QUAL_AGG_FRAME_LIMIT_MAX (64)
> +#define LINK_QUAL_AGG_FRAME_LIMIT_MAX 0x3f
> #define LINK_QUAL_AGG_FRAME_LIMIT_MIN (0)
why are you switching of hex now? Just putting (63) in there is not
enough?
Regards
Marcel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iwlwifi: fix aggregation limit
2009-07-01 15:06 ` Marcel Holtmann
@ 2009-07-01 15:09 ` Johannes Berg
2009-07-01 15:52 ` Luciano Coelho
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2009-07-01 15:09 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: John Linville, Reinette Chatre, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
On Wed, 2009-07-01 at 08:06 -0700, Marcel Holtmann wrote:
> Hi Johannes,
>
> > According to the documentation, the limit is 0x3f == 63, not 64.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > ---
> > It seems bug 2018 is related to the link quality command, because it
> > seems I can trivially trigger it or similar bugs that way, but this
> > doesn't fix it.
> >
> > --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:33.804427206 +0200
> > +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:38.924427592 +0200
> > @@ -1922,7 +1922,7 @@ struct iwl_link_qual_general_params {
> > #define LINK_QUAL_AGG_DISABLE_START_MIN (0)
> >
> > #define LINK_QUAL_AGG_FRAME_LIMIT_DEF (31)
> > -#define LINK_QUAL_AGG_FRAME_LIMIT_MAX (64)
> > +#define LINK_QUAL_AGG_FRAME_LIMIT_MAX 0x3f
> > #define LINK_QUAL_AGG_FRAME_LIMIT_MIN (0)
>
> why are you switching of hex now? Just putting (63) in there is not
> enough?
It would be, obviously, but the doc says 0x3f.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iwlwifi: fix aggregation limit
2009-07-01 15:09 ` Johannes Berg
@ 2009-07-01 15:52 ` Luciano Coelho
2009-07-01 16:02 ` Marcel Holtmann
0 siblings, 1 reply; 5+ messages in thread
From: Luciano Coelho @ 2009-07-01 15:52 UTC (permalink / raw)
To: ext Johannes Berg
Cc: Marcel Holtmann, John Linville, Reinette Chatre, linux-wireless
ext Johannes Berg wrote:
> On Wed, 2009-07-01 at 08:06 -0700, Marcel Holtmann wrote:
>
>> Hi Johannes,
>>
>>
>>> According to the documentation, the limit is 0x3f == 63, not 64.
>>>
>>> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>>> ---
>>> It seems bug 2018 is related to the link quality command, because it
>>> seems I can trivially trigger it or similar bugs that way, but this
>>> doesn't fix it.
>>>
>>> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:33.804427206 +0200
>>> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:38.924427592 +0200
>>> @@ -1922,7 +1922,7 @@ struct iwl_link_qual_general_params {
>>> #define LINK_QUAL_AGG_DISABLE_START_MIN (0)
>>>
>>> #define LINK_QUAL_AGG_FRAME_LIMIT_DEF (31)
>>> -#define LINK_QUAL_AGG_FRAME_LIMIT_MAX (64)
>>> +#define LINK_QUAL_AGG_FRAME_LIMIT_MAX 0x3f
>>> #define LINK_QUAL_AGG_FRAME_LIMIT_MIN (0)
>>>
>> why are you switching of hex now? Just putting (63) in there is not
>> enough?
>>
>
> It would be, obviously, but the doc says 0x3f.
>
I think it would be nicer to have (63) or otherwise convert all the
macros to use the 0x format. Does the spec use 0x1f for the default
value, for instance, instead of (31)?
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iwlwifi: fix aggregation limit
2009-07-01 15:52 ` Luciano Coelho
@ 2009-07-01 16:02 ` Marcel Holtmann
0 siblings, 0 replies; 5+ messages in thread
From: Marcel Holtmann @ 2009-07-01 16:02 UTC (permalink / raw)
To: Luciano Coelho
Cc: ext Johannes Berg, John Linville, Reinette Chatre, linux-wireless
Hi Johannes,
> >>> According to the documentation, the limit is 0x3f == 63, not 64.
> >>>
> >>> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> >>> ---
> >>> It seems bug 2018 is related to the link quality command, because it
> >>> seems I can trivially trigger it or similar bugs that way, but this
> >>> doesn't fix it.
> >>>
> >>> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:33.804427206 +0200
> >>> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:38.924427592 +0200
> >>> @@ -1922,7 +1922,7 @@ struct iwl_link_qual_general_params {
> >>> #define LINK_QUAL_AGG_DISABLE_START_MIN (0)
> >>>
> >>> #define LINK_QUAL_AGG_FRAME_LIMIT_DEF (31)
> >>> -#define LINK_QUAL_AGG_FRAME_LIMIT_MAX (64)
> >>> +#define LINK_QUAL_AGG_FRAME_LIMIT_MAX 0x3f
> >>> #define LINK_QUAL_AGG_FRAME_LIMIT_MIN (0)
> >>>
> >> why are you switching of hex now? Just putting (63) in there is not
> >> enough?
> >>
> >
> > It would be, obviously, but the doc says 0x3f.
> >
>
> I think it would be nicer to have (63) or otherwise convert all the
> macros to use the 0x format. Does the spec use 0x1f for the default
> value, for instance, instead of (31)?
I would agree. Use (31) and let the commit message explain it. Not that
it is really that important.
Regards
Marcel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-07-01 16:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-01 12:57 [PATCH] iwlwifi: fix aggregation limit Johannes Berg
2009-07-01 15:06 ` Marcel Holtmann
2009-07-01 15:09 ` Johannes Berg
2009-07-01 15:52 ` Luciano Coelho
2009-07-01 16:02 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox