[PATCH] libertas: remove unused lbs_cmd_802_11_inactivity_timeout()

[PATCH] libertas: remove unused lbs_cmd_802_11_inactivity_timeout()

[Holger Schurig]

Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

--- linux-wl.orig/drivers/net/wireless/libertas/cmd.c
+++ linux-wl/drivers/net/wireless/libertas/cmd.c
@@ -273,33 +273,6 @@
 	return 0;
 }
 
-int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
-				      uint16_t cmd_action, uint16_t *timeout)
-{
-	struct cmd_ds_802_11_inactivity_timeout cmd;
-	int ret;
-
-	lbs_deb_enter(LBS_DEB_CMD);
-
-	cmd.hdr.command = cpu_to_le16(CMD_802_11_INACTIVITY_TIMEOUT);
-	cmd.hdr.size = cpu_to_le16(sizeof(cmd));
-
-	cmd.action = cpu_to_le16(cmd_action);
-
-	if (cmd_action == CMD_ACT_SET)
-		cmd.timeout = cpu_to_le16(*timeout);
-	else
-		cmd.timeout = 0;
-
-	ret = lbs_cmd_with_response(priv, CMD_802_11_INACTIVITY_TIMEOUT, &cmd);
-
-	if (!ret)
-		*timeout = le16_to_cpu(cmd.timeout);
-
-	lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
-	return 0;
-}
-
 int lbs_cmd_802_11_sleep_params(struct lbs_private *priv, uint16_t cmd_action,
 				struct sleep_params *sp)
 {
--- linux-wl.orig/drivers/net/wireless/libertas/cmd.h
+++ linux-wl/drivers/net/wireless/libertas/cmd.h
@@ -135,9 +135,6 @@
 int lbs_cmd_802_11_rate_adapt_rateset(struct lbs_private *priv,
 				      uint16_t cmd_action);
 
-int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
-				      uint16_t cmd_action, uint16_t *timeout);
-
 int lbs_cmd_802_11_set_wep(struct lbs_private *priv, uint16_t cmd_action,
 			   struct assoc_request *assoc);
 
--- linux-wl.orig/drivers/net/wireless/libertas/host.h
+++ linux-wl/drivers/net/wireless/libertas/host.h
@@ -621,16 +621,6 @@
 	__le16 reserved;
 } __attribute__ ((packed));
 
-struct cmd_ds_802_11_inactivity_timeout {
-	struct cmd_header hdr;
-
-	/* ACT_GET/ACT_SET */
-	__le16 action;
-
-	/* Inactivity timeout in msec */
-	__le16 timeout;
-} __attribute__ ((packed));
-
 struct cmd_ds_802_11_rf_channel {
 	struct cmd_header hdr;
 

-- 
http://www.holgerschurig.de

Re: [PATCH] libertas: remove unused lbs_cmd_802_11_inactivity_timeout()

[Dan Williams]

On Fri, 2009-10-16 at 17:34 +0200, Holger Schurig wrote:
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

We were going to use this at one point, but we haven't yet, so we can
add it back when we do.

Acked-by: Dan Williams <dcbw@redhat.com>

> --- linux-wl.orig/drivers/net/wireless/libertas/cmd.c
> +++ linux-wl/drivers/net/wireless/libertas/cmd.c
> @@ -273,33 +273,6 @@
>  	return 0;
>  }
>  
> -int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
> -				      uint16_t cmd_action, uint16_t *timeout)
> -{
> -	struct cmd_ds_802_11_inactivity_timeout cmd;
> -	int ret;
> -
> -	lbs_deb_enter(LBS_DEB_CMD);
> -
> -	cmd.hdr.command = cpu_to_le16(CMD_802_11_INACTIVITY_TIMEOUT);
> -	cmd.hdr.size = cpu_to_le16(sizeof(cmd));
> -
> -	cmd.action = cpu_to_le16(cmd_action);
> -
> -	if (cmd_action == CMD_ACT_SET)
> -		cmd.timeout = cpu_to_le16(*timeout);
> -	else
> -		cmd.timeout = 0;
> -
> -	ret = lbs_cmd_with_response(priv, CMD_802_11_INACTIVITY_TIMEOUT, &cmd);
> -
> -	if (!ret)
> -		*timeout = le16_to_cpu(cmd.timeout);
> -
> -	lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
> -	return 0;
> -}
> -
>  int lbs_cmd_802_11_sleep_params(struct lbs_private *priv, uint16_t cmd_action,
>  				struct sleep_params *sp)
>  {
> --- linux-wl.orig/drivers/net/wireless/libertas/cmd.h
> +++ linux-wl/drivers/net/wireless/libertas/cmd.h
> @@ -135,9 +135,6 @@
>  int lbs_cmd_802_11_rate_adapt_rateset(struct lbs_private *priv,
>  				      uint16_t cmd_action);
>  
> -int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
> -				      uint16_t cmd_action, uint16_t *timeout);
> -
>  int lbs_cmd_802_11_set_wep(struct lbs_private *priv, uint16_t cmd_action,
>  			   struct assoc_request *assoc);
>  
> --- linux-wl.orig/drivers/net/wireless/libertas/host.h
> +++ linux-wl/drivers/net/wireless/libertas/host.h
> @@ -621,16 +621,6 @@
>  	__le16 reserved;
>  } __attribute__ ((packed));
>  
> -struct cmd_ds_802_11_inactivity_timeout {
> -	struct cmd_header hdr;
> -
> -	/* ACT_GET/ACT_SET */
> -	__le16 action;
> -
> -	/* Inactivity timeout in msec */
> -	__le16 timeout;
> -} __attribute__ ((packed));
> -
>  struct cmd_ds_802_11_rf_channel {
>  	struct cmd_header hdr;
>  
> 

Re: [PATCH] libertas: remove unused lbs_cmd_802_11_inactivity_timeout()

[Holger Schurig]

> We were going to use this at one point, but we haven't yet, so we can
> add it back when we do.

So, what does this actually do?

-- 
http://www.holgerschurig.de

Re: [PATCH] libertas: remove unused lbs_cmd_802_11_inactivity_timeout()

[Dan Williams]

On Mon, 2009-10-19 at 08:54 +0200, Holger Schurig wrote:
> > We were going to use this at one point, but we haven't yet, so we can
> > add it back when we do.
> 
> So, what does this actually do?

Pretty much like it sounds; it lets the device go to into powersave at
user-specified interval after the last TX or RX, instead of having to
wait one full beacon of inactivity.

Dan

Re: [PATCH] libertas: remove unused lbs_cmd_802_11_inactivity_timeout()

[Holger Schurig]

> Pretty much like it sounds; it lets the device go to into
> powersave at user-specified interval after the last TX or RX,
> instead of having to wait one full beacon of inactivity.

Ok, nice.

But it could also have sounded like "report how long the card was 
inactive", e.g. what "iw XXX link" can show.



Do you already have any idea about how to make those things like 
TCP, inactivity etc available in NL80211/cfg80211 ?


-- 
http://www.holgerschurig.de