libertas sdio firmware

libertas sdio firmware

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi,

Was just looking at the libertas driver and noticed that the SPI part
loads firmware as such:

snprintf(helper_fw, IF_SPI_FW_NAME_MAX, "libertas/gspi%d_hlp.bin", ...
etc.

while the SDIO part just uses
ret = request_firmware(&fw, card->helper, &card->func->dev);

which ends up requesting sd8686_helper.bin instead of
libertas/sd8686_helper.bin, as far as I can tell. That means the
linux-firmware git repo won't work out of the box, I think?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: libertas sdio firmware

[Dan Williams]

On Mon, 2009-10-26 at 08:16 +0100, Johannes Berg wrote:
> Hi,
> 
> Was just looking at the libertas driver and noticed that the SPI part
> loads firmware as such:
> 
> snprintf(helper_fw, IF_SPI_FW_NAME_MAX, "libertas/gspi%d_hlp.bin", ...
> etc.
> 
> while the SDIO part just uses
> ret = request_firmware(&fw, card->helper, &card->func->dev);
> 
> which ends up requesting sd8686_helper.bin instead of
> libertas/sd8686_helper.bin, as far as I can tell. That means the
> linux-firmware git repo won't work out of the box, I think?

Correct.  I stuffed all the firmware into the git repo that I could
find, but because I didn't quite get around to doing firmware name
fallbacks in the driver (so we don't break existing installs) the driver
hasn't been updated yet.

I'd like to do a couple fallbacks actually; something like a priority
ordering of [<old name>, libertas/sd8686_helper_v9.bin,
libertas/sd8686_helper_v8.bin] so that we can use either v8 and v9
firmware if we need to; not all the v9 functionality has been added yet.
v10 is out there too but I haven't seen it in the wild yet.

Dan