From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"j@w1.fi" <j@w1.fi>, Kalle Valo <kalle.valo@nokia.com>
Subject: Re: [PATCH v3 1/1] mac80211: tell driver when dtim change detected
Date: Mon, 25 Jan 2010 19:33:38 +0100 [thread overview]
Message-ID: <1264444418.23766.53.camel@johannes.local> (raw)
In-Reply-To: <43e72e891001251018h1a62e1ccn4a7d1411fa2c0615@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Mon, 2010-01-25 at 10:18 -0800, Luis R. Rodriguez wrote:
> > Yes, since 0 is nonsensical, we would use 1 instead.
>
> OK -- it seems we have a consensus waiting for a beacon would be good,
> but it would be good to have something in for stable. Is the patch Guy
> posted acceptable for that purpose? That is, merge this for now until
> we get beacon wait implemented prior to association.
Not sure we even need it in stable that badly? It seems it only hurts
power consumption somewhat. And I just implemented waiting today too.
Although Bob has a point, we could change the way we pass the DTIM
period to the driver, only pass it in the powersave callbacks, and then
we could associate without it and just enable powersave only after
receiving a beacon. That assumes that drivers don't use it for anything
else though, of course, but I don't see anything else you could use it
for really.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2010-01-25 18:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 21:39 [PATCH v3 1/1] mac80211: tell driver when dtim change detected wey-yi.w.guy
2010-01-22 19:03 ` Johannes Berg
2010-01-22 19:20 ` Luis R. Rodriguez
2010-01-22 19:46 ` Johannes Berg
2010-01-22 23:44 ` Luis R. Rodriguez
2010-01-22 23:45 ` Luis R. Rodriguez
2010-01-23 0:11 ` Guy, Wey-Yi
2010-01-23 0:23 ` Luis R. Rodriguez
2010-01-23 0:22 ` Guy, Wey-Yi
2010-01-23 12:46 ` Johannes Berg
2010-01-25 18:18 ` Luis R. Rodriguez
2010-01-25 18:33 ` Johannes Berg [this message]
2010-01-25 19:55 ` Luis R. Rodriguez
2010-01-25 20:06 ` Johannes Berg
2010-01-26 8:41 ` Kalle Valo
2010-01-25 18:32 ` Jouni Malinen
2010-01-25 18:36 ` Johannes Berg
2010-01-25 18:38 ` Johannes Berg
2010-01-23 8:23 ` Kalle Valo
2010-01-25 18:35 ` Jouni Malinen
2010-01-25 20:11 ` Johannes Berg
2010-01-25 20:46 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264444418.23766.53.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=kalle.valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox