From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: wey-yi.w.guy@intel.com, linux-wireless@vger.kernel.org, j@w1.fi,
Kalle Valo <kalle.valo@nokia.com>
Subject: Re: [PATCH v3 1/1] mac80211: tell driver when dtim change detected
Date: Fri, 22 Jan 2010 15:45:32 -0800 [thread overview]
Message-ID: <43e72e891001221545h5d0b295xfacd59bb65322d5a@mail.gmail.com> (raw)
In-Reply-To: <43e72e891001221544j1b1bd67ao8dfcf4d0dd12dd81@mail.gmail.com>
On Fri, Jan 22, 2010 at 3:44 PM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> On Fri, Jan 22, 2010 at 11:46 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
>> On Fri, 2010-01-22 at 11:20 -0800, Luis R. Rodriguez wrote:
>>
>>> > Previously, we would switch the channel completely to the new operating
>>> > channel before even probing the AP. That way, we would virtually always
>>> > receive a beacon from the new AP between the time we started the
>>> > association process (probe,auth,assoc) and configuring the driver.
>>> >
>>> > Now with the new changes that use the off-channel work, we may return to
>>> > the old "operating" channel, which may be no particular channel, between
>>> > all these steps. Thus, if there's no beacon between any of probe
>>> > request/response, auth "request"/"response", assoc request/response, we
>>> > never get one, and this situation happens.
>>> >
>>> > I see two solutions, apart from this special-case patch fixing
>>> >
>>> > First, we could go back to the original behaviour if we have just one
>>> > virtual interface. But that still leaves us with the race, we might do
>>> > all three frame exchanges within a beacon interval and still miss the
>>> > beacon, we just tend to not do that and get a beacon.
>>>
>>> Curious, what symptoms were seen when the dtim was not propagated
>>> prior to association, did the STA just not wake up for the right dtim
>>> interval when in PS mode?
>>
>> Yes, I don't really know exactly what happens,
>
> OK -- Wey, can you elaborate a little as to how you found this and
> what you were seeing? Does the device not go into PS mode at all?
>
BTW I ask more details because I'm trying to determine if this would
be a stable fix or not.
Luis
next prev parent reply other threads:[~2010-01-22 23:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 21:39 [PATCH v3 1/1] mac80211: tell driver when dtim change detected wey-yi.w.guy
2010-01-22 19:03 ` Johannes Berg
2010-01-22 19:20 ` Luis R. Rodriguez
2010-01-22 19:46 ` Johannes Berg
2010-01-22 23:44 ` Luis R. Rodriguez
2010-01-22 23:45 ` Luis R. Rodriguez [this message]
2010-01-23 0:11 ` Guy, Wey-Yi
2010-01-23 0:23 ` Luis R. Rodriguez
2010-01-23 0:22 ` Guy, Wey-Yi
2010-01-23 12:46 ` Johannes Berg
2010-01-25 18:18 ` Luis R. Rodriguez
2010-01-25 18:33 ` Johannes Berg
2010-01-25 19:55 ` Luis R. Rodriguez
2010-01-25 20:06 ` Johannes Berg
2010-01-26 8:41 ` Kalle Valo
2010-01-25 18:32 ` Jouni Malinen
2010-01-25 18:36 ` Johannes Berg
2010-01-25 18:38 ` Johannes Berg
2010-01-23 8:23 ` Kalle Valo
2010-01-25 18:35 ` Jouni Malinen
2010-01-25 20:11 ` Johannes Berg
2010-01-25 20:46 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e891001221545h5d0b295xfacd59bb65322d5a@mail.gmail.com \
--to=mcgrof@gmail.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox