From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 14/14] iwlwifi: apply settings when finishing scan
Date: Fri, 10 Sep 2010 08:56:55 -0700 [thread overview]
Message-ID: <1284134215.6054.29.camel@wwguy-ubuntu> (raw)
In-Reply-To: <1284128807-11436-15-git-send-email-sgruszka@redhat.com>
On Fri, 2010-09-10 at 07:26 -0700, Stanislaw Gruszka wrote:
> Even is someone else complete scanning in mac80211, apply rxon and
> tx power settings if gets scan complete notification from hardware.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Wey-Yi W Guy <wey-yi.w.guy@intel.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-scan.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
> index 65b7cb4..599573f 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-scan.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
> @@ -573,7 +573,7 @@ static void iwl_bg_scan_completed(struct work_struct *work)
>
> if (!test_and_clear_bit(STATUS_SCANNING, &priv->status)) {
> IWL_DEBUG_SCAN(priv, "Scan already completed.\n");
> - goto out;
> + goto out_settings;
> }
>
> if (priv->is_internal_short_scan && !aborted) {
> @@ -599,6 +599,7 @@ static void iwl_bg_scan_completed(struct work_struct *work)
> out_complete:
> iwl_complete_scan(priv, aborted);
>
> +out_settings:
> /* Can we still talk to firmware ? */
> if (!iwl_is_ready_rf(priv))
> goto out;
next prev parent reply other threads:[~2010-09-10 15:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 14:26 [PATCH 0/14 v3] iwlwifi: rewrite iwl-scan.c to avoid race conditions Stanislaw Gruszka
2010-09-10 14:26 ` [PATCH 01/14] iwlwifi: remove unused conf variables Stanislaw Gruszka
2010-09-10 15:49 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 02/14] iwlwifi: unify scan start checks Stanislaw Gruszka
2010-09-10 15:49 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 03/14] iwlwifi: move scan completed flags handling Stanislaw Gruszka
2010-09-10 15:50 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 04/14] iwlwifi: cancel scan when down the device Stanislaw Gruszka
2010-09-10 15:50 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 05/14] iwlwifi: report scan completion when abort fail Stanislaw Gruszka
2010-09-10 15:51 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 06/14] iwlwifi: rework iwl_scan_cancel_timeout Stanislaw Gruszka
2010-09-10 15:52 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 07/14] iwlwifi: rewrite scan completion Stanislaw Gruszka
2010-09-10 15:52 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 08/14] iwlwifi: force scan complete after timeout Stanislaw Gruszka
2010-09-10 15:53 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 09/14] iwlwifi: assure we complete scan in scan_abort and scan_check works Stanislaw Gruszka
2010-09-10 15:54 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 10/14] iwlwifi: do not force complete scan too early Stanislaw Gruszka
2010-09-10 15:54 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 11/14] mac80211: wait for scan work complete before restarting hw Stanislaw Gruszka
2010-09-10 15:55 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 12/14] iwlwifi: cleanup scan initiate check Stanislaw Gruszka
2010-09-10 15:55 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 13/14] iwlwifi: use IWL_DEBUG_SCAN for debug scanning Stanislaw Gruszka
2010-09-10 15:56 ` Guy, Wey-Yi
2010-09-10 14:26 ` [PATCH 14/14] iwlwifi: apply settings when finishing scan Stanislaw Gruszka
2010-09-10 15:56 ` Guy, Wey-Yi [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-13 12:46 [PATCH 0/14 v4] iwlwifi: rewrite iwl-scan.c to avoid race conditions Stanislaw Gruszka
2010-09-13 12:46 ` [PATCH 14/14] iwlwifi: apply settings when finishing scan Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284134215.6054.29.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox