From: Jonas Gorski <jonas.gorski@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>,
Henry Ptasinski <henryp@broadcom.com>,
Dowan Kim <dowan@broadcom.com>,
Roland Vossen <rvossen@broadcom.com>,
Arend van Spriel <arend@broadcom.com>
Subject: [RFT 0/8] Clean proto/ethernet.h and remove it.
Date: Wed, 19 Jan 2011 23:35:24 +0100 [thread overview]
Message-ID: <1295476532-21130-1-git-send-email-jonas.gorski@gmail.com> (raw)
After the short discussion I started cleaning up the code, and this is the
first small patch series. I thought I'll start with rather simple
replacements.
This series replaces everything from proto/ethernet.h with their
equivalents in the kernel and then removes it.
It does not fix previously existing style violations, so checkpatch still
complains about too long lines; I will address these in further patches.
Since I do not have a supported device at hand, I'd be happy if anyone
could test that I didn't break anything while replacing things. Especially
in patch 7 (Replace ether_addr with fixed size array) I might have broken
something.
--
Jonas
Jonas Gorski (8):
staging: brcm80211: Remove unused ETHER_<foo> macros.
staging: brcm80211: Use linux ethhdr struct.
staging: brcm80211: Remove unused ETHER_<foo> defines.
staging: brcm80211: Remove ETHER_MAX_LEN definition.
staging: brcm80211: Remove ETHER_TYPE_BRCM.
staging: brcm80211: Remove static ether_bcast.
staging: brcm80211: Replace ether_addr with fixed size array.
staging: brcm80211: Remove proto/ethernet.h.
drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 19 +++---
drivers/staging/brcm80211/brcmfmac/dhd_sdio.c | 1 -
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 5 +-
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.h | 1 -
drivers/staging/brcm80211/brcmfmac/wl_iw.c | 5 +-
drivers/staging/brcm80211/brcmfmac/wl_iw.h | 1 -
drivers/staging/brcm80211/include/bcmcdc.h | 3 +-
drivers/staging/brcm80211/include/bcmutils.h | 2 +-
drivers/staging/brcm80211/include/proto/802.11.h | 20 +++---
drivers/staging/brcm80211/include/proto/bcmevent.h | 8 ++-
drivers/staging/brcm80211/include/proto/ethernet.h | 72 --------------------
drivers/staging/brcm80211/include/proto/wpa.h | 2 -
drivers/staging/brcm80211/include/wlioctl.h | 23 +++---
drivers/staging/brcm80211/sys/wl_mac80211.c | 3 +-
drivers/staging/brcm80211/sys/wlc_alloc.c | 4 +-
drivers/staging/brcm80211/sys/wlc_ampdu.c | 2 +-
drivers/staging/brcm80211/sys/wlc_bmac.c | 34 ++++-----
drivers/staging/brcm80211/sys/wlc_bmac.h | 14 ++--
drivers/staging/brcm80211/sys/wlc_bsscfg.h | 6 +-
drivers/staging/brcm80211/sys/wlc_key.h | 2 +-
drivers/staging/brcm80211/sys/wlc_mac80211.c | 55 +++++++--------
drivers/staging/brcm80211/sys/wlc_mac80211.h | 12 ++--
drivers/staging/brcm80211/sys/wlc_pub.h | 10 ++--
drivers/staging/brcm80211/sys/wlc_scb.h | 2 +-
drivers/staging/brcm80211/util/bcmsrom.c | 18 ++---
drivers/staging/brcm80211/util/bcmutils.c | 5 +-
26 files changed, 117 insertions(+), 212 deletions(-)
delete mode 100644 drivers/staging/brcm80211/include/proto/ethernet.h
next reply other threads:[~2011-01-19 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 22:35 Jonas Gorski [this message]
2011-01-19 22:35 ` [RFT 1/8] staging: brcm80211: Remove unused ETHER_<foo> macros Jonas Gorski
2011-01-19 22:35 ` [RFT 2/8] staging: brcm80211: Use linux ethhdr struct Jonas Gorski
2011-01-19 22:35 ` [RFT 3/8] staging: brcm80211: Remove unused ETHER_<foo> defines Jonas Gorski
2011-01-19 22:35 ` [RFT 4/8] staging: brcm80211: Remove ETHER_MAX_LEN definition Jonas Gorski
2011-01-19 22:35 ` [RFT 5/8] staging: brcm80211: Remove ETHER_TYPE_BRCM Jonas Gorski
2011-01-19 22:35 ` [RFT 6/8] staging: brcm80211: Remove static ether_bcast Jonas Gorski
2011-01-19 22:35 ` [RFT 7/8] staging: brcm80211: Replace ether_addr with fixed size array Jonas Gorski
2011-01-19 22:35 ` [RFT 8/8] staging: brcm80211: Remove proto/ethernet.h Jonas Gorski
2011-01-20 8:58 ` [RFT 0/8] Clean proto/ethernet.h and remove it Arend Van Spriel
2011-01-20 11:12 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295476532-21130-1-git-send-email-jonas.gorski@gmail.com \
--to=jonas.gorski@gmail.com \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=dowan@broadcom.com \
--cc=henryp@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox