Linux wireless drivers development
 help / color / mirror / Atom feed
From: Jonas Gorski <jonas.gorski@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>,
	Henry Ptasinski <henryp@broadcom.com>,
	Dowan Kim <dowan@broadcom.com>,
	Roland Vossen <rvossen@broadcom.com>,
	Arend van Spriel <arend@broadcom.com>
Subject: [RFT 4/8] staging: brcm80211: Remove ETHER_MAX_LEN definition.
Date: Wed, 19 Jan 2011 23:35:28 +0100	[thread overview]
Message-ID: <1295476532-21130-5-git-send-email-jonas.gorski@gmail.com> (raw)
In-Reply-To: <1295476532-21130-4-git-send-email-jonas.gorski@gmail.com>

Since ETHER_MAX_LEN is only used for CDC_MAX_MSG_SIZE, directly use the value
in bcmcdc.h and remove the definition.

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
 drivers/staging/brcm80211/include/bcmcdc.h         |    3 +--
 drivers/staging/brcm80211/include/proto/ethernet.h |    2 --
 2 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/brcm80211/include/bcmcdc.h b/drivers/staging/brcm80211/include/bcmcdc.h
index 10c1ddc..e56470e 100644
--- a/drivers/staging/brcm80211/include/bcmcdc.h
+++ b/drivers/staging/brcm80211/include/bcmcdc.h
@@ -13,7 +13,6 @@
  * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
  * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
-#include <proto/ethernet.h>
 
 typedef struct cdc_ioctl {
 	u32 cmd;		/* ioctl command value */
@@ -24,7 +23,7 @@ typedef struct cdc_ioctl {
 } cdc_ioctl_t;
 
 /* Max valid buffer size that can be sent to the dongle */
-#define CDC_MAX_MSG_SIZE   ETHER_MAX_LEN
+#define CDC_MAX_MSG_SIZE	1518
 
 /* len field is divided into input and output buffer lengths */
 #define CDCL_IOC_OUTLEN_MASK   0x0000FFFF	/* maximum or expected
diff --git a/drivers/staging/brcm80211/include/proto/ethernet.h b/drivers/staging/brcm80211/include/proto/ethernet.h
index 1176df9..bc99842 100644
--- a/drivers/staging/brcm80211/include/proto/ethernet.h
+++ b/drivers/staging/brcm80211/include/proto/ethernet.h
@@ -21,8 +21,6 @@
 
 #include <packed_section_start.h>
 
-#define	ETHER_MAX_LEN		1518
-
 #define	ETHER_TYPE_BRCM		0x886c
 
 BWL_PRE_PACKED_STRUCT struct ether_addr {
-- 
1.5.6.5


  reply	other threads:[~2011-01-19 22:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 22:35 [RFT 0/8] Clean proto/ethernet.h and remove it Jonas Gorski
2011-01-19 22:35 ` [RFT 1/8] staging: brcm80211: Remove unused ETHER_<foo> macros Jonas Gorski
2011-01-19 22:35   ` [RFT 2/8] staging: brcm80211: Use linux ethhdr struct Jonas Gorski
2011-01-19 22:35     ` [RFT 3/8] staging: brcm80211: Remove unused ETHER_<foo> defines Jonas Gorski
2011-01-19 22:35       ` Jonas Gorski [this message]
2011-01-19 22:35         ` [RFT 5/8] staging: brcm80211: Remove ETHER_TYPE_BRCM Jonas Gorski
2011-01-19 22:35           ` [RFT 6/8] staging: brcm80211: Remove static ether_bcast Jonas Gorski
2011-01-19 22:35             ` [RFT 7/8] staging: brcm80211: Replace ether_addr with fixed size array Jonas Gorski
2011-01-19 22:35               ` [RFT 8/8] staging: brcm80211: Remove proto/ethernet.h Jonas Gorski
2011-01-20  8:58 ` [RFT 0/8] Clean proto/ethernet.h and remove it Arend Van Spriel
2011-01-20 11:12   ` Jonas Gorski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295476532-21130-5-git-send-email-jonas.gorski@gmail.com \
    --to=jonas.gorski@gmail.com \
    --cc=arend@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=dowan@broadcom.com \
    --cc=henryp@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rvossen@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox