From: Jonas Gorski <jonas.gorski@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>,
Henry Ptasinski <henryp@broadcom.com>,
Dowan Kim <dowan@broadcom.com>,
Roland Vossen <rvossen@broadcom.com>,
Arend van Spriel <arend@broadcom.com>
Subject: [RFT 6/8] staging: brcm80211: Remove static ether_bcast.
Date: Wed, 19 Jan 2011 23:35:30 +0100 [thread overview]
Message-ID: <1295476532-21130-7-git-send-email-jonas.gorski@gmail.com> (raw)
In-Reply-To: <1295476532-21130-6-git-send-email-jonas.gorski@gmail.com>
Remove the static struct ether_bcast and use memset for setting the broadcast
address instead of copying the struct.
_
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 4 ++--
drivers/staging/brcm80211/brcmfmac/wl_iw.c | 4 ++--
drivers/staging/brcm80211/include/proto/ethernet.h | 2 --
drivers/staging/brcm80211/sys/wlc_mac80211.c | 3 +--
4 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
index 991463f..c7e3837 100644
--- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
@@ -648,7 +648,7 @@ wl_cfg80211_change_iface(struct wiphy *wiphy, struct net_device *ndev,
static void wl_iscan_prep(struct wl_scan_params *params, struct wlc_ssid *ssid)
{
- memcpy(¶ms->bssid, ðer_bcast, ETH_ALEN);
+ memset(¶ms->bssid, 0xff, ETH_ALEN);
params->bss_type = DOT11_BSSTYPE_ANY;
params->scan_type = 0;
params->nprobes = -1;
@@ -1373,7 +1373,7 @@ wl_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev,
memcpy(&join_params.ssid.SSID, sme->ssid, join_params.ssid.SSID_len);
join_params.ssid.SSID_len = htod32(join_params.ssid.SSID_len);
wl_update_prof(wl, NULL, &join_params.ssid, WL_PROF_SSID);
- memcpy(&join_params.params.bssid, ðer_bcast, ETH_ALEN);
+ memset(&join_params.params.bssid, 0xff, ETH_ALEN);
wl_ch_to_chanspec(wl->channel, &join_params, &join_params_size);
WL_DBG("join_param_size %d\n", join_params_size);
diff --git a/drivers/staging/brcm80211/brcmfmac/wl_iw.c b/drivers/staging/brcm80211/brcmfmac/wl_iw.c
index db6e68e..346b190 100644
--- a/drivers/staging/brcm80211/brcmfmac/wl_iw.c
+++ b/drivers/staging/brcm80211/brcmfmac/wl_iw.c
@@ -1015,7 +1015,7 @@ static int wl_iw_iscan_prep(wl_scan_params_t *params, wlc_ssid_t *ssid)
{
int err = 0;
- memcpy(¶ms->bssid, ðer_bcast, ETH_ALEN);
+ memset(¶ms->bssid, 0xff, ETH_ALEN);
params->bss_type = DOT11_BSSTYPE_ANY;
params->scan_type = 0;
params->nprobes = -1;
@@ -1919,7 +1919,7 @@ wl_iw_set_essid(struct net_device *dev,
memcpy(&join_params.ssid.SSID, g_ssid.SSID, g_ssid.SSID_len);
join_params.ssid.SSID_len = htod32(g_ssid.SSID_len);
- memcpy(&join_params.params.bssid, ðer_bcast, ETH_ALEN);
+ memset(&join_params.params.bssid, 0xff, ETH_ALEN);
wl_iw_ch_to_chanspec(g_wl_iw_params.target_channel, &join_params,
&join_params_size);
diff --git a/drivers/staging/brcm80211/include/proto/ethernet.h b/drivers/staging/brcm80211/include/proto/ethernet.h
index 77deb94..b401fda 100644
--- a/drivers/staging/brcm80211/include/proto/ethernet.h
+++ b/drivers/staging/brcm80211/include/proto/ethernet.h
@@ -25,8 +25,6 @@ BWL_PRE_PACKED_STRUCT struct ether_addr {
u8 octet[ETH_ALEN];
} BWL_POST_PACKED_STRUCT;
-static const struct ether_addr ether_bcast = { {255, 255, 255, 255, 255, 255} };
-
#include <packed_section_end.h>
#endif /* _NET_ETHERNET_H_ */
diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c b/drivers/staging/brcm80211/sys/wlc_mac80211.c
index 9c57573..0bf70fc 100644
--- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
+++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
@@ -7658,8 +7658,7 @@ wlc_bcn_prb_template(struct wlc_info *wlc, uint type, ratespec_t bcn_rspec,
/* DUR is 0 for multicast bcn, or filled in by MAC for prb resp */
/* A1 filled in by MAC for prb resp, broadcast for bcn */
if (type == FC_BEACON)
- bcopy((const char *)ðer_bcast, (char *)&h->da,
- ETH_ALEN);
+ memset(&h->da, 0xff, ETH_ALEN);
bcopy((char *)&cfg->cur_etheraddr, (char *)&h->sa, ETH_ALEN);
bcopy((char *)&cfg->BSSID, (char *)&h->bssid, ETH_ALEN);
--
1.5.6.5
next prev parent reply other threads:[~2011-01-19 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 22:35 [RFT 0/8] Clean proto/ethernet.h and remove it Jonas Gorski
2011-01-19 22:35 ` [RFT 1/8] staging: brcm80211: Remove unused ETHER_<foo> macros Jonas Gorski
2011-01-19 22:35 ` [RFT 2/8] staging: brcm80211: Use linux ethhdr struct Jonas Gorski
2011-01-19 22:35 ` [RFT 3/8] staging: brcm80211: Remove unused ETHER_<foo> defines Jonas Gorski
2011-01-19 22:35 ` [RFT 4/8] staging: brcm80211: Remove ETHER_MAX_LEN definition Jonas Gorski
2011-01-19 22:35 ` [RFT 5/8] staging: brcm80211: Remove ETHER_TYPE_BRCM Jonas Gorski
2011-01-19 22:35 ` Jonas Gorski [this message]
2011-01-19 22:35 ` [RFT 7/8] staging: brcm80211: Replace ether_addr with fixed size array Jonas Gorski
2011-01-19 22:35 ` [RFT 8/8] staging: brcm80211: Remove proto/ethernet.h Jonas Gorski
2011-01-20 8:58 ` [RFT 0/8] Clean proto/ethernet.h and remove it Arend Van Spriel
2011-01-20 11:12 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295476532-21130-7-git-send-email-jonas.gorski@gmail.com \
--to=jonas.gorski@gmail.com \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=dowan@broadcom.com \
--cc=henryp@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox