* [RFC] wireless: Fix rate mask for scan request
@ 2011-09-15 9:14 Rajkumar Manoharan
2011-09-15 9:19 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Rajkumar Manoharan @ 2011-09-15 9:14 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, Rajkumar Manoharan, stable
The scan request received from cfg80211_connect do not
have proper rate mast. So the probe request sent on each
channel do not have proper the supported rates ie.
Cc: stable@kernel.org
Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
---
net/wireless/sme.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index b7b6ff8..8b6ef34 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -118,6 +118,7 @@ static int cfg80211_conn_scan(struct wireless_dev *wdev)
i++, j++)
request->channels[i] =
&wdev->wiphy->bands[band]->channels[j];
+ request->rates[band] = (u32) -1;
}
}
request->n_channels = n_channels;
--
1.7.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC] wireless: Fix rate mask for scan request
2011-09-15 9:14 [RFC] wireless: Fix rate mask for scan request Rajkumar Manoharan
@ 2011-09-15 9:19 ` Johannes Berg
2011-09-15 9:19 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2011-09-15 9:19 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: linux-wireless
On Thu, 2011-09-15 at 14:44 +0530, Rajkumar Manoharan wrote:
> The scan request received from cfg80211_connect do not
> have proper rate mast. So the probe request sent on each
> channel do not have proper the supported rates ie.
>
> Cc: stable@kernel.org
> Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
> ---
> net/wireless/sme.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index b7b6ff8..8b6ef34 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -118,6 +118,7 @@ static int cfg80211_conn_scan(struct wireless_dev *wdev)
> i++, j++)
> request->channels[i] =
> &wdev->wiphy->bands[band]->channels[j];
> + request->rates[band] = (u32) -1;
Please use
(1 << wiphy->bands[band]->n_bitrates) - 1;
so we don't have invalid bits set.
Also, CC stable doesn't work that way -- you don't CC them, you just
write into it "Cc: stable@kernel.org". This makes them pick out the
patch later once it got applied.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-15 9:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-15 9:14 [RFC] wireless: Fix rate mask for scan request Rajkumar Manoharan
2011-09-15 9:19 ` Johannes Berg
2011-09-15 9:19 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).