From: Johannes Berg <johannes@sipsolutions.net>
To: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Cc: linux-wireless@vger.kernel.org, javier@cozybit.com,
linville@tuxdriver.com, devel@lists.open80211s.org
Subject: Re: [PATCH] fix the increment of unicast/multicast counters for forwarded PREQ
Date: Mon, 07 May 2012 09:43:23 +0200 [thread overview]
Message-ID: <1336376603.4325.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1336106215-7431-1-git-send-email-yeohchunyeow@gmail.com> (sfid-20120504_063859_676671_B65B65D0)
On Fri, 2012-05-04 at 12:36 +0800, Chun-Yeow Yeoh wrote:
> Forwarded PREQ is either unicast or multicast. The appropriate counters
> should be incremented accordingly.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
> ---
> net/mac80211/mesh_hwmp.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> index 503016f..f0695e5 100644
> --- a/net/mac80211/mesh_hwmp.c
> +++ b/net/mac80211/mesh_hwmp.c
> @@ -603,7 +603,10 @@ static void hwmp_preq_frame_process(struct ieee80211_sub_if_data *sdata,
> hopcount, ttl, cpu_to_le32(lifetime),
> cpu_to_le32(metric), cpu_to_le32(preq_id),
> sdata);
> - ifmsh->mshstats.fwded_mcast++;
> + if (da != broadcast_addr)
In addition to what Javier said. Err. Think about this comparison again.
johannes
next prev parent reply other threads:[~2012-05-07 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 4:36 [PATCH] fix the increment of unicast/multicast counters for forwarded PREQ Chun-Yeow Yeoh
[not found] ` <CAPjQAd8YK9Zy17z5KQ2uxVk7mH2qK-SLT3UObbU46NTkGv-cDA@mail.gmail.com>
2012-05-04 6:45 ` Yeoh Chun-Yeow
2012-05-07 7:43 ` Johannes Berg [this message]
2012-05-07 8:58 ` Yeoh Chun-Yeow
2012-05-07 9:21 ` Johannes Berg
2012-05-07 10:19 ` Yeoh Chun-Yeow
2012-05-07 10:41 ` Kalle Valo
2012-05-07 10:54 ` Yeoh Chun-Yeow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336376603.4325.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox