From: Johannes Berg <johannes@sipsolutions.net>
To: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>
Cc: linux-wireless@vger.kernel.org, javier@cozybit.com,
linville@tuxdriver.com, devel@lists.open80211s.org
Subject: Re: [PATCH] fix the increment of unicast/multicast counters for forwarded PREQ
Date: Mon, 07 May 2012 11:21:02 +0200 [thread overview]
Message-ID: <1336382462.4325.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAEFj9857DWGCcnF20nKYEDb0_p1K_iYLR1F=oLNAx6NjwPQE9w@mail.gmail.com> (sfid-20120507_105843_577233_4BE81F52)
Hi,
> If the destination address is not broadcast frame, the number of
> forwarded unicast frame is increased. And the other way round. Not
> correct?
>
> + if (!is_multicast_ether_addr(da))
> + ifmsh->mshstats.fwded_unicast++;
> + else
> + ifmsh->mshstats.fwded_mcast++;
No, your new code is fine, but this
> >> + if (da != broadcast_addr)
will never be false.
johannes
next prev parent reply other threads:[~2012-05-07 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 4:36 [PATCH] fix the increment of unicast/multicast counters for forwarded PREQ Chun-Yeow Yeoh
[not found] ` <CAPjQAd8YK9Zy17z5KQ2uxVk7mH2qK-SLT3UObbU46NTkGv-cDA@mail.gmail.com>
2012-05-04 6:45 ` Yeoh Chun-Yeow
2012-05-07 7:43 ` Johannes Berg
2012-05-07 8:58 ` Yeoh Chun-Yeow
2012-05-07 9:21 ` Johannes Berg [this message]
2012-05-07 10:19 ` Yeoh Chun-Yeow
2012-05-07 10:41 ` Kalle Valo
2012-05-07 10:54 ` Yeoh Chun-Yeow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336382462.4325.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox