From: Kalle Valo <kvalo@adurom.com>
To: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, javier@cozybit.com,
linville@tuxdriver.com, devel@lists.open80211s.org
Subject: Re: [PATCH] fix the increment of unicast/multicast counters for forwarded PREQ
Date: Mon, 07 May 2012 13:41:30 +0300 [thread overview]
Message-ID: <874nrs9sth.fsf@purkki.adurom.net> (raw)
In-Reply-To: <CAEFj9855PG1Qv5RBWPJJc5tyKRz5LZZaY8qRU7oAwryH5G8L7A@mail.gmail.com> (Yeoh Chun-Yeow's message of "Mon, 7 May 2012 18:19:50 +0800")
Yeoh Chun-Yeow <yeohchunyeow@gmail.com> writes:
> Hi, Johannes
>
>>> >> + if (da != broadcast_addr)
>>
>> will never be false.
>
> Hmm, but I have a check on this and it works. The previous line will
> set the da either as broadcast addr or unicast addr.
You are comparing pointers, not addresses. If you do that on purpose
then it's very confusing.
--
Kalle Valo
next prev parent reply other threads:[~2012-05-07 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 4:36 [PATCH] fix the increment of unicast/multicast counters for forwarded PREQ Chun-Yeow Yeoh
[not found] ` <CAPjQAd8YK9Zy17z5KQ2uxVk7mH2qK-SLT3UObbU46NTkGv-cDA@mail.gmail.com>
2012-05-04 6:45 ` Yeoh Chun-Yeow
2012-05-07 7:43 ` Johannes Berg
2012-05-07 8:58 ` Yeoh Chun-Yeow
2012-05-07 9:21 ` Johannes Berg
2012-05-07 10:19 ` Yeoh Chun-Yeow
2012-05-07 10:41 ` Kalle Valo [this message]
2012-05-07 10:54 ` Yeoh Chun-Yeow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nrs9sth.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox