From: Joe Perches <joe@perches.com>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
Cc: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>,
"John W . Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
"Luis R . Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH v8 4/4] dynamic_debug: dynamic hex dump
Date: Thu, 15 Nov 2012 09:32:03 -0800 [thread overview]
Message-ID: <1353000723.17678.10.camel@joe-AO722> (raw)
In-Reply-To: <CAMXE1-oypT8XMZBxBwKP5v9+xW4QS579PtmhCgPhxhodHoVETw@mail.gmail.com>
On Thu, 2012-11-15 at 17:55 +0200, Andrei Emeltchenko wrote:
> Hi Vladimir,
>
> On Thu, Nov 15, 2012 at 1:17 PM, Vladimir Kondratiev
> <qca_vkondrat@qca.qualcomm.com> wrote:
> > Introduce print_hex_dump_debug() that can be dynamically controlled, similar to
> > pr_debug.
>
> You could just use "%*ph" specifier in pr_debug
Possibly true, but %*ph doesn't emit ascii nor
does it format a large block of data very well.
Maybe use of
pr_debug("%*ph", len, buf)
vs
print_hex_dump_bytes("prefix", DUMP_PREFIX_<STYLE>, buf, len)
could be described a bit in dynamic_debug_howto
or perhaps all of the various printk, dev_<level>,
<subsystem>_<level> styles and all the various
debugging options would be better described in a
new printk_howto
prev parent reply other threads:[~2012-11-15 17:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 11:16 [PATCH v8 0/4] driver for 60g Wilocity chip wil6210 Vladimir Kondratiev
2012-11-15 11:16 ` [PATCH v8 1/4] wireless: Driver for 60GHz card wil6210 Vladimir Kondratiev
2012-11-15 11:17 ` [PATCH v8 2/4] wireless: allow Atheros card to not depend on ath.ko Vladimir Kondratiev
2012-11-21 11:18 ` Vladimir Kondratiev
2012-11-21 14:55 ` Kalle Valo
[not found] ` <CAB=NE6XP83QVZ8Vv1R247HLW3ep_quQ8yP9STKT5L_jMrpxUOA@mail.gmail.com>
2012-11-22 7:08 ` Kalle Valo
[not found] ` <CAB=NE6V2DTQD9Q2Chj0ftk4oYE1aykCJtCaeAu_WSp3RTVSjhA@mail.gmail.com>
2012-11-26 17:54 ` Vladimir Kondratiev
2012-11-28 13:55 ` Vladimir Kondratiev
2012-11-28 14:13 ` John W. Linville
2012-11-28 15:51 ` Vladimir Kondratiev
2012-11-28 15:53 ` [PATCH v2] " Vladimir Kondratiev
2012-11-28 16:59 ` Vladimir Kondratiev
[not found] ` <1585902.GCBvcuyASu@lx-vladimir>
2012-12-01 2:38 ` [RFC] How to manage dependency between patches John W. Linville
2012-12-02 8:14 ` Vladimir Kondratiev
2012-11-28 16:57 ` [PATCH v2] wireless: allow Atheros card to not depend on ath.ko Vladimir Kondratiev
2012-12-03 13:03 ` Vladimir Kondratiev
2012-12-03 13:46 ` John W. Linville
2012-12-04 7:59 ` Vladimir Kondratiev
2012-12-11 19:28 ` Kalle Valo
2012-12-12 8:07 ` Vladimir Kondratiev
2012-12-12 8:58 ` [PATCH] wireless: fix Atheros drivers compilation Vladimir Kondratiev
2012-12-12 17:08 ` Kalle Valo
2012-12-12 17:25 ` [PATCH v2] " Vladimir Kondratiev
2012-12-12 17:32 ` Kalle Valo
2012-11-15 11:17 ` [PATCH v8 3/4] wireless: integrate wil6210 driver into build Vladimir Kondratiev
2012-11-15 11:17 ` [PATCH v8 4/4] dynamic_debug: dynamic hex dump Vladimir Kondratiev
2012-11-15 11:52 ` Vladimir Kondratiev
2012-11-15 15:55 ` Andrei Emeltchenko
2012-11-15 17:32 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353000723.17678.10.camel@joe-AO722 \
--to=joe@perches.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox