public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
	Kalle Valo <kvalo@adurom.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	<linux-wireless@vger.kernel.org>
Subject: [PATCH v2] wireless: allow Atheros card to not depend on ath.ko
Date: Wed, 28 Nov 2012 18:57:19 +0200	[thread overview]
Message-ID: <1967408.WlU5HIbjCs@lx-vladimir> (raw)
In-Reply-To: <20121128141319.GA9118@tuxdriver.com>


There are 2 different things:
- sub-menu for "Atheros Wireless cards" family
- module ath.ko with common Atheros code

Until now, they both used to depend on the same Kconfig variable ATH_COMMON.
Thus, being "Atheros card" and "depending on ath.ko" was the same.

To allow module to belong to the
"Atheros Wireless cards" family but not use ath.ko,
2 conditions above need to be separated.

So, this patch introduce new Kconfig variable ATH_CARDS for belonging
to the "Atheros Wireless Cards" family; while ATH_COMMON becomes hidden
variable to express dependency on common Atheros code in ath.ko. Modules
that depend on this common code now express it by setting ATH_COMMON.

Right now, ath6kl do not depend on common code and thus do not set ATH_COMMON.

Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
---
 drivers/net/wireless/ath/Kconfig          |    7 +++++--
 drivers/net/wireless/ath/ar5523/Kconfig   |    1 +
 drivers/net/wireless/ath/ath5k/Kconfig    |    1 +
 drivers/net/wireless/ath/ath9k/Kconfig    |    1 +
 drivers/net/wireless/ath/carl9170/Kconfig |    1 +
 5 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/Kconfig 
b/drivers/net/wireless/ath/Kconfig
index c25dcf1..1a67a4f 100644
--- a/drivers/net/wireless/ath/Kconfig
+++ b/drivers/net/wireless/ath/Kconfig
@@ -1,4 +1,7 @@
-menuconfig ATH_COMMON
+config ATH_COMMON
+	tristate
+
+menuconfig ATH_CARDS
 	tristate "Atheros Wireless Cards"
 	depends on CFG80211 && (!UML || BROKEN)
 	---help---
@@ -14,7 +17,7 @@ menuconfig ATH_COMMON
 
 	  http://wireless.kernel.org/en/users/Drivers/Atheros
 
-if ATH_COMMON
+if ATH_CARDS
 
 config ATH_DEBUG
 	bool "Atheros wireless debugging"
diff --git a/drivers/net/wireless/ath/ar5523/Kconfig 
b/drivers/net/wireless/ath/ar5523/Kconfig
index 11d99ee..0d320cc 100644
--- a/drivers/net/wireless/ath/ar5523/Kconfig
+++ b/drivers/net/wireless/ath/ar5523/Kconfig
@@ -1,6 +1,7 @@
 config AR5523
        tristate "Atheros AR5523 wireless driver support"
        depends on MAC80211 && USB
+       select ATH_COMMON
        select FW_LOADER
        ---help---
          This module add support for AR5523 based USB dongles such as D-Link
diff --git a/drivers/net/wireless/ath/ath5k/Kconfig 
b/drivers/net/wireless/ath/ath5k/Kconfig
index 338c5c4..c9f81a3 100644
--- a/drivers/net/wireless/ath/ath5k/Kconfig
+++ b/drivers/net/wireless/ath/ath5k/Kconfig
@@ -1,6 +1,7 @@
 config ATH5K
 	tristate "Atheros 5xxx wireless cards support"
 	depends on (PCI || ATHEROS_AR231X) && MAC80211
+	select ATH_COMMON
 	select MAC80211_LEDS
 	select LEDS_CLASS
 	select NEW_LEDS
diff --git a/drivers/net/wireless/ath/ath9k/Kconfig 
b/drivers/net/wireless/ath/ath9k/Kconfig
index c7aa664..5fc15bf 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -17,6 +17,7 @@ config ATH9K_BTCOEX_SUPPORT
 config ATH9K
 	tristate "Atheros 802.11n wireless cards support"
 	depends on MAC80211
+	select ATH_COMMON
 	select ATH9K_HW
 	select MAC80211_LEDS
 	select LEDS_CLASS
diff --git a/drivers/net/wireless/ath/carl9170/Kconfig 
b/drivers/net/wireless/ath/carl9170/Kconfig
index 267d5dc..13a2045 100644
--- a/drivers/net/wireless/ath/carl9170/Kconfig
+++ b/drivers/net/wireless/ath/carl9170/Kconfig
@@ -1,6 +1,7 @@
 config CARL9170
 	tristate "Linux Community AR9170 802.11n USB support"
 	depends on USB && MAC80211 && EXPERIMENTAL
+	select ATH_COMMON
 	select FW_LOADER
 	select CRC32
 	help
-- 
1.7.10.4



  parent reply	other threads:[~2012-11-28 16:57 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 11:16 [PATCH v8 0/4] driver for 60g Wilocity chip wil6210 Vladimir Kondratiev
2012-11-15 11:16 ` [PATCH v8 1/4] wireless: Driver for 60GHz card wil6210 Vladimir Kondratiev
2012-11-15 11:17 ` [PATCH v8 2/4] wireless: allow Atheros card to not depend on ath.ko Vladimir Kondratiev
2012-11-21 11:18   ` Vladimir Kondratiev
2012-11-21 14:55     ` Kalle Valo
     [not found]       ` <CAB=NE6XP83QVZ8Vv1R247HLW3ep_quQ8yP9STKT5L_jMrpxUOA@mail.gmail.com>
2012-11-22  7:08         ` Kalle Valo
     [not found]           ` <CAB=NE6V2DTQD9Q2Chj0ftk4oYE1aykCJtCaeAu_WSp3RTVSjhA@mail.gmail.com>
2012-11-26 17:54             ` Vladimir Kondratiev
2012-11-28 13:55               ` Vladimir Kondratiev
2012-11-28 14:13                 ` John W. Linville
2012-11-28 15:51                   ` Vladimir Kondratiev
2012-11-28 15:53                   ` [PATCH v2] " Vladimir Kondratiev
2012-11-28 16:59                     ` Vladimir Kondratiev
     [not found]                     ` <1585902.GCBvcuyASu@lx-vladimir>
2012-12-01  2:38                       ` [RFC] How to manage dependency between patches John W. Linville
2012-12-02  8:14                         ` Vladimir Kondratiev
2012-11-28 16:57                   ` Vladimir Kondratiev [this message]
2012-12-03 13:03                     ` [PATCH v2] wireless: allow Atheros card to not depend on ath.ko Vladimir Kondratiev
2012-12-03 13:46                       ` John W. Linville
2012-12-04  7:59                         ` Vladimir Kondratiev
2012-12-11 19:28                     ` Kalle Valo
2012-12-12  8:07                       ` Vladimir Kondratiev
2012-12-12  8:58                       ` [PATCH] wireless: fix Atheros drivers compilation Vladimir Kondratiev
2012-12-12 17:08                         ` Kalle Valo
2012-12-12 17:25                           ` [PATCH v2] " Vladimir Kondratiev
2012-12-12 17:32                             ` Kalle Valo
2012-11-15 11:17 ` [PATCH v8 3/4] wireless: integrate wil6210 driver into build Vladimir Kondratiev
2012-11-15 11:17 ` [PATCH v8 4/4] dynamic_debug: dynamic hex dump Vladimir Kondratiev
2012-11-15 11:52   ` Vladimir Kondratiev
2012-11-15 15:55   ` Andrei Emeltchenko
2012-11-15 17:32     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1967408.WlU5HIbjCs@lx-vladimir \
    --to=qca_vkondrat@qca.qualcomm.com \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@adurom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=rodrigue@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox