From: Gabor Juhos <juhosg@openwrt.org>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
Gabor Juhos <juhosg@openwrt.org>
Subject: [PATCH v3 09/20] rt2x00: rt2800lib: fix default TX power values for RT3593
Date: Mon, 8 Jul 2013 16:08:24 +0200 [thread overview]
Message-ID: <1373292515-21332-10-git-send-email-juhosg@openwrt.org> (raw)
In-Reply-To: <1373292515-21332-1-git-send-email-juhosg@openwrt.org>
The TX power values in the EEPROM are using
a different format for the RT3593 chip. The
default TX power value uses bits 0..4 only.
Bits 5..8 contains value for fine grained
power control. Additionally, the lower and
upper limits of the TX power values are the
same for both bands.
Improve the rt2800_txpower_to_dev function,
in order to compute the correct default power
values for the RT3593 chip as well.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
---
Changes since v2: ---
---
drivers/net/wireless/rt2x00/rt2800.h | 7 +++++++
drivers/net/wireless/rt2x00/rt2800lib.c | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
index d3e8f6d..69749ba5 100644
--- a/drivers/net/wireless/rt2x00/rt2800.h
+++ b/drivers/net/wireless/rt2x00/rt2800.h
@@ -2603,6 +2603,10 @@ enum rt2800_eeprom_word {
#define EEPROM_TXPOWER_A_1 FIELD16(0x00ff)
#define EEPROM_TXPOWER_A_2 FIELD16(0xff00)
+/* EEPROM_TXPOWER_{A,G} fields for RT3593 */
+#define EEPROM_TXPOWER_ALC FIELD8(0x1f)
+#define EEPROM_TXPOWER_FINE_CTRL FIELD8(0xe0)
+
/*
* EEPROM temperature compensation boundaries 802.11A
* MINUS4: If the actual TSSI is below this boundary, tx power needs to be
@@ -2884,6 +2888,9 @@ enum rt2800_eeprom_word {
#define MAX_A_TXPOWER 15
#define DEFAULT_TXPOWER 5
+#define MIN_A_TXPOWER_3593 0
+#define MAX_A_TXPOWER_3593 31
+
#define TXPOWER_G_FROM_DEV(__txpower) \
((__txpower) > MAX_G_TXPOWER) ? DEFAULT_TXPOWER : (__txpower)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 1738a9d..b11f0b0 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2728,8 +2728,15 @@ static char rt2800_txpower_to_dev(struct rt2x00_dev *rt2x00dev,
unsigned int channel,
char txpower)
{
+ if (rt2x00_rt(rt2x00dev, RT3593))
+ txpower = rt2x00_get_field8(txpower, EEPROM_TXPOWER_ALC);
+
if (channel <= 14)
return clamp_t(char, txpower, MIN_G_TXPOWER, MAX_G_TXPOWER);
+
+ if (rt2x00_rt(rt2x00dev, RT3593))
+ return clamp_t(char, txpower, MIN_A_TXPOWER_3593,
+ MAX_A_TXPOWER_3593);
else
return clamp_t(char, txpower, MIN_A_TXPOWER, MAX_A_TXPOWER);
}
--
1.7.10
next prev parent reply other threads:[~2013-07-08 14:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 14:08 [PATCH v3 00/20] rt2x00: add experimental support for RT3593 Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 01/20] rt2x00: rt2800lib: add MAC register initialization " Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 02/20] rt2x00: rt2800lib: add BBP " Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 03/20] rt2x00: rt2800lib: add RFCSR " Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 04/20] rt2x00: rt2800lib: add BBP post " Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 05/20] rt2x00: rt2800lib: add TX power configuration " Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 06/20] rt2x00: rt2800lib: fix BBP1_TX_ANTENNA field configuration for 3T devices Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 07/20] rt2x00: rt2800lib: fix antenna configuration for RT3593 Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 08/20] rt2x00: rt2800lib: add rt2800_txpower_to_dev helper Gabor Juhos
2013-07-08 14:08 ` Gabor Juhos [this message]
2013-07-08 14:08 ` [PATCH v3 10/20] rt2x00: rt2800lib: introduce rt2800_get_txmixer_gain_{24,5}g helpers Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 11/20] rt2x00: rt2800lib: hardcode TX mixer gain values for RT3593 Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 12/20] rt2x00: rt2800lib: fix LNA_A[12] " Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 13/20] rt2x00: rt2800lib: add default_power3 field for three-chain devices Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 14/20] rt2x00: rt2800lib: add rf_vals for RF3053 Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 15/20] rt2x00: rt2800lib: add channel configuration " Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 16/20] rt2x00: rt2800lib: enable VCO recalibration " Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 17/20] rt2x00: rt2800lib: enable RF3053 support Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 18/20] rt2x00: rt2800lib: enable RT3593 support Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 19/20] rt2x00: rt2800usb: use correct [RT]XWI size for RT3593 Gabor Juhos
2013-07-08 14:08 ` [PATCH v3 20/20] rt2x00: rt2800usb: add USB device ID for Linksys AE3000 Gabor Juhos
2013-07-22 15:48 ` [PATCH v3 00/20] rt2x00: add experimental support for RT3593 Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373292515-21332-10-git-send-email-juhosg@openwrt.org \
--to=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox