Linux wireless drivers development
 help / color / mirror / Atom feed
* [RFC] mac80211: at76x50x_usb driver broken by commit 3afc216.. and RX path involved in scan
@ 2014-05-17 15:42 Andrea Merello
  2014-05-18  7:10 ` Grumbach, Emmanuel
  2014-05-19 14:29 ` Johannes Berg
  0 siblings, 2 replies; 14+ messages in thread
From: Andrea Merello @ 2014-05-17 15:42 UTC (permalink / raw)
  To: johannes.berg, emmanuel.grumbach
  Cc: Linux Wireless List, oku, joerg.albert, alex, n0_5p4m_p13453,
	proski, agx, kalle.valo, sesmo, John Linville

Hello,

It happened that since Emmanuel's commit
3afc2167f60a327a2c1e1e2600ef209a3c2b75b7 (cfg80211/mac80211: ignore
signal if the frame was heard on wrong channel) my atmel-based wifi
device couldn't scan anymore.

I looked at this issue and I found the cause, but currently I have
some doubts, and I would like asking for clarification and comments,
before trying to patch the driver or mac80211 itself....

The problem is triggered because the at76x50x-usb driver does not
provide frequency information in rx_status (and AFAIK it difficultly
could do that during scan right now).

Emmanuel's commit make certain mac80211 functions stop getting the
channel information from the beacon/probe response, and start getting
it from rx_status, but the channel results now NULL, and the frame is
discarded.
The relevant check is done in mlme.c, ieee80211_rx_bss_info
if (!channel)
    return;
just after Emmanuel's change.

So my first question is:
Are mac80211 drivers obligated to report this information?
Does this commit just rely on something that should be already in that
way (and the at7950x-usb driver is simply buggy not doing this)?
Reading Emmanuel's commit message it seems he didn't have any
intention to introduce this constraint now.

Said that, I dig in mac80211 code, and I saw Emmanuel commit does
affect frames processed in sta (and ibss, but i didn't look at this)
rx path.

Summarizing it a bit, the call path should be:
 __ieee80211_rx_handle_packet()
ieee80211_invoke_rx_handlers()
ieee80211_rx_h_mgmt()
-- work queue --
ieee80211_iface_work()
ieee80211_sta_rx_queued_mgmt()
ieee80211_rx_bss_info() - patched to get channel from driver's rx_status.
And finally
ieee80211_bss_info_update()

is this right?

What is surprising for me is that
 __ieee80211_rx_handle_packet()
contains a shorter path for updating BSS information by
ieee80211_scan_rx() that directly calls
ieee80211_bss_info_update()

The interesting thing is that ieee80211_scan_rx was already written in
the way Emmanuel's patched ieee80211_rx_bss_info(): It get channel
info from rx_status.

This suggests that the at79c50x-usb driver, prior to Emmanuel's
commit, was able to scan by getting mgmt frames processed by the
former, longer, RX path, and that the ieee80211_scan_rx() path was
never really used.

If this is correct, my question is:
Isn't this a redundant path duplication (provided that drivers
supplies channel information)?

This seems to be confirmed by the fact that if I modify mac80211 to
avoid discarding frame without channel information (by putting a valid
channel information directly in mac80211 just before the check for
NULL), the scan works by either doing this in ieee80211_scan_rx() or
in ieee80211_rx_bss_info() (reverting Emmanuel change in mlme.c).

Finally my latest question is:
Emmanuel's patch makes cfg80211_inform_bss_width_frame() compare the
RX channel and the actual BSS channel (known from beacon/probe
response), and it does this by comparing the two pointers.

Are we guaranteed that only one instance of every channel object does
exists ? isn't it safer to compare the frequency field value?

Thank you
Andrea

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2014-06-05 14:10 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-17 15:42 [RFC] mac80211: at76x50x_usb driver broken by commit 3afc216.. and RX path involved in scan Andrea Merello
2014-05-18  7:10 ` Grumbach, Emmanuel
2014-05-19 14:29 ` Johannes Berg
2014-05-19 14:49   ` Johannes Berg
2014-05-19 15:42     ` Andrea Merello
2014-05-19 16:02       ` Johannes Berg
2014-05-19 16:05         ` Andrea Merello
2014-05-26 11:53           ` Andrea Merello
2014-05-28 14:02             ` Johannes Berg
2014-05-31 18:54               ` Andrea Merello
2014-06-03 19:57                 ` Johannes Berg
2014-06-04 21:02                   ` Andrea Merello
2014-06-05 12:32                     ` Johannes Berg
2014-06-05 14:10                       ` [PATCH] at76c50x: fix scan does not work with latest mac80211 Andrea Merello

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox