* Re: drivers/net/wireless/intel/iwlwifi/pcie/trans.c: 2 * suspicious code ?
[not found] <VI1PR08MB1022D85586276BFDE1125B539C630@VI1PR08MB1022.eurprd08.prod.outlook.com>
@ 2017-01-09 11:16 ` Luca Coelho
0 siblings, 0 replies; only message in thread
From: Luca Coelho @ 2017-01-09 11:16 UTC (permalink / raw)
To: David Binderman, johannes.berg@intel.com,
emmanuel.grumbach@intel.com, linuxwifi@intel.com,
kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On Fri, 2017-01-06 at 17:47 +0000, David Binderman wrote:
> Hello there,
Hi David,
> 1.
>
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2039:14: warning: decrement of a boolean expression [-Wbool-operation]
>
> Source code is
>
> txq->block--;
>
> Maybe someone got a bool and a int mixed up ?
>
> 2.
>
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2045:14: warning: increment of a boolean expression [-Wbool-operation]
>
> Duplicate a few lines further down.
Emmanuel has fixed this in our internal tree and I'll be sending it out
together with our normal upstreaming process.
Thanks for reporting!
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] only message in thread