From: Johannes Berg <johannes@sipsolutions.net>
To: Maxin John <maxin.john@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: Makefile: support out-of-tree builds
Date: Mon, 27 Apr 2026 11:43:54 +0200 [thread overview]
Message-ID: <1672e78507b643f4610265f018ccddcb141ee726.camel@sipsolutions.net> (raw)
In-Reply-To: <20260423113154.1070521-1-maxin.john@gmail.com> (sfid-20260423_133158_126940_B575589B)
On Thu, 2026-04-23 at 14:31 +0300, Maxin John wrote:
> Enable out-of-tree builds without modifying the source tree.
> Out-of-tree builds are required by build frameworks such as OpenEmbedded.
You should probably say how this is intended to be used, clearly not in
the O= way that the kernel has, for example.
> +SRCDIR := $(dir $(lastword $(MAKEFILE_LIST)))
That doesn't work if there's whitespace anywhere along the path.
> +CPPFLAGS += -I$(SRCDIR)
> +CPPFLAGS += -I.
The "-I." seems questionable since you evidently intend to have "."
*not* be the source dir?
Overall it might be simpler to actually do it with the kernel-style O=
so you just need to change all the outputs, rather than all the inputs?
johannes
next prev parent reply other threads:[~2026-04-27 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 11:31 [PATCH] iw: Makefile: support out-of-tree builds Maxin John
2026-04-27 9:43 ` Johannes Berg [this message]
2026-04-28 17:12 ` Maxin John
2026-04-28 17:18 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1672e78507b643f4610265f018ccddcb141ee726.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=maxin.john@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox