From: Johannes Berg <johannes@sipsolutions.net>
To: Maxin John <maxin.john@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: Makefile: support out-of-tree builds
Date: Tue, 28 Apr 2026 19:18:32 +0200 [thread overview]
Message-ID: <d283177dcb103834969df55290fda3120c000f5c.camel@sipsolutions.net> (raw)
In-Reply-To: <afDqaQc-Vxoz3OEL@Thor.home> (sfid-20260428_191213_746464_F0BF06E9)
On Tue, 2026-04-28 at 20:12 +0300, Maxin John wrote:
>
> > > +CPPFLAGS += -I.
> >
> > The "-I." seems questionable since you evidently intend to have "."
> > *not* be the source dir?
>
> The -I. was intended to ensure that generated files such as
> nl80211-commands.inc, which are produced in the build directory,
> remain discoverable by the compiler. Agree that it doesn't look right
> and I will update it.
Oh, I guess that makes sense, maybe just add a comment? But that's after
guessing you somehow intend to call 'make -f ../src/Makefile' or
something, which seems a little odd to me?
johannes
prev parent reply other threads:[~2026-04-28 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 11:31 [PATCH] iw: Makefile: support out-of-tree builds Maxin John
2026-04-27 9:43 ` Johannes Berg
2026-04-28 17:12 ` Maxin John
2026-04-28 17:18 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d283177dcb103834969df55290fda3120c000f5c.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=maxin.john@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox