Re: [PATCH] iw: Makefile: support out-of-tree builds

[Maxin John <maxin.john@gmail.com>]

Hi Johannes,

Thanks for the review comments.

On Mon, Apr 27, 2026 at 11:43:54AM +0200, Johannes Berg wrote:
> On Thu, 2026-04-23 at 14:31 +0300, Maxin John wrote:
> > Enable out-of-tree builds without modifying the source tree.
> > Out-of-tree builds are required by build frameworks such as OpenEmbedded.
> 
> You should probably say how this is intended to be used, clearly not in
> the O= way that the kernel has, for example.

I will clarify the intended usage in the next iteration.  

> > +SRCDIR := $(dir $(lastword $(MAKEFILE_LIST)))
> 
> That doesn't work if there's whitespace anywhere along the path.
> 
> > +CPPFLAGS += -I$(SRCDIR)
> > +CPPFLAGS += -I.
> 
> The "-I." seems questionable since you evidently intend to have "."
> *not* be the source dir?

The -I. was intended to ensure that generated files such as
nl80211-commands.inc, which are produced in the build directory,
 remain discoverable by the compiler. Agree that it doesn't look right
and I will update it. 

> 
> Overall it might be simpler to actually do it with the kernel-style O=
> so you just need to change all the outputs, rather than all the inputs?

Got it. I will update it as per your comments and send a v2.

> 
> johannes

Best Regards,
Maxin