From: Sujith <m.sujith@gmail.com>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: Felix Fietkau <nbd@nbd.name>, Felix Fietkau <nbd@openwrt.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Sujith.Manoharan@atheros.com
Subject: Re: [PATCH v3 1/8] ath9k_hw: only use the PCIe disable register write sequence for AR5416
Date: Mon, 13 Dec 2010 21:33:35 +0530 [thread overview]
Message-ID: <19718.17367.708420.358035@gargle.gargle.HOWL> (raw)
In-Reply-To: <20101213134638.GA4622@vmraj-lnx.users.atheros.com>
Rajkumar Manoharan wrote:
> > Because it is only relevant for USB based devices.
> >
> True. This part is also applicable for HTC device like UB91.
Not really, this is not required for USB devices.
ath9k_hw_disablepcie() should probably not be called for USB devices.
We should also remove the useless calls to ath9k_hw_configpcipowersave()
in htc_start() and htc_stop().
Sujith
prev parent reply other threads:[~2010-12-13 16:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 23:51 [PATCH v3 1/8] ath9k_hw: only use the PCIe disable register write sequence for AR5416 Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 2/8] ath9k_hw: clean up duplicate and unnused eeprom related defines Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 3/8] ath9k_hw: merge ath9k_hw_get_gain_boundaries_pdadcs between eeprom_def.c and eeprom_4k.c Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 4/8] ath9k_hw: merge the ar9287 version of ath9k_hw_get_gain_boundaries_pdadcs Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 5/8] ath9k_hw: remove antenna configuration eeprom ops and variables Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 6/8] ath9k_hw: clean up SREV version checks Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 7/8] ath9k_hw: remove ah->beacon_interval Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 8/8] ath9k_hw: remove ah->txpower_indexoffset Felix Fietkau
2010-12-13 11:12 ` [PATCH v3 1/8] ath9k_hw: only use the PCIe disable register write sequence for AR5416 Rajkumar Manoharan
2010-12-13 13:37 ` Felix Fietkau
2010-12-13 13:46 ` Rajkumar Manoharan
2010-12-13 16:03 ` Sujith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19718.17367.708420.358035@gargle.gargle.HOWL \
--to=m.sujith@gmail.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@nbd.name \
--cc=nbd@openwrt.org \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox