Re: [PATCH v3 1/8] ath9k_hw: only use the PCIe disable register write sequence for AR5416

[Rajkumar Manoharan <rmanoharan@atheros.com>]

On Mon, Dec 13, 2010 at 07:07:53PM +0530, Felix Fietkau wrote:
> On 13.12.2010, at 12:12, Rajkumar Manoharan <rmanoharan@atheros.com> wrote:
> 
> > On Sun, Dec 12, 2010 at 05:21:07AM +0530, Felix Fietkau wrote:
> >> Newer chips do not need this, and maybe these register writes could have
> >> negative side effects on newer hardware.
> >> 
> >> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> >> ---
> >> drivers/net/wireless/ath/ath9k/hw.c |    6 +-----
> >> 1 files changed, 1 insertions(+), 5 deletions(-)
> >> 
> >> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
> >> index 516227f..7bc6d22 100644
> >> --- a/drivers/net/wireless/ath/ath9k/hw.c
> >> +++ b/drivers/net/wireless/ath/ath9k/hw.c
> >> @@ -284,11 +284,9 @@ static void ath9k_hw_read_revisions(struct ath_hw *ah)
> >> 
> >> static void ath9k_hw_disablepcie(struct ath_hw *ah)
> >> {
> >> -    if (AR_SREV_9100(ah))
> >> +    if (!AR_SREV_5416(ah))
> >>        return;
> >> 
> >> -    ENABLE_REGWRITE_BUFFER(ah);
> > 
> > Why to disable multiple register write?
> Because it is only relevant for USB based devices.
>
True. This part is also applicable for HTC device like UB91.

--
Rajkumar