From: Rajkumar Manoharan <rmanoharan@atheros.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH v3 1/8] ath9k_hw: only use the PCIe disable register write sequence for AR5416
Date: Mon, 13 Dec 2010 16:42:07 +0530 [thread overview]
Message-ID: <20101213111207.GA3121@vmraj-lnx.users.atheros.com> (raw)
In-Reply-To: <1292111474-70939-1-git-send-email-nbd@openwrt.org>
On Sun, Dec 12, 2010 at 05:21:07AM +0530, Felix Fietkau wrote:
> Newer chips do not need this, and maybe these register writes could have
> negative side effects on newer hardware.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
> drivers/net/wireless/ath/ath9k/hw.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
> index 516227f..7bc6d22 100644
> --- a/drivers/net/wireless/ath/ath9k/hw.c
> +++ b/drivers/net/wireless/ath/ath9k/hw.c
> @@ -284,11 +284,9 @@ static void ath9k_hw_read_revisions(struct ath_hw *ah)
>
> static void ath9k_hw_disablepcie(struct ath_hw *ah)
> {
> - if (AR_SREV_9100(ah))
> + if (!AR_SREV_5416(ah))
> return;
>
> - ENABLE_REGWRITE_BUFFER(ah);
Why to disable multiple register write?
--
Rajkumar
next prev parent reply other threads:[~2010-12-13 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 23:51 [PATCH v3 1/8] ath9k_hw: only use the PCIe disable register write sequence for AR5416 Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 2/8] ath9k_hw: clean up duplicate and unnused eeprom related defines Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 3/8] ath9k_hw: merge ath9k_hw_get_gain_boundaries_pdadcs between eeprom_def.c and eeprom_4k.c Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 4/8] ath9k_hw: merge the ar9287 version of ath9k_hw_get_gain_boundaries_pdadcs Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 5/8] ath9k_hw: remove antenna configuration eeprom ops and variables Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 6/8] ath9k_hw: clean up SREV version checks Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 7/8] ath9k_hw: remove ah->beacon_interval Felix Fietkau
2010-12-11 23:51 ` [PATCH v3 8/8] ath9k_hw: remove ah->txpower_indexoffset Felix Fietkau
2010-12-13 11:12 ` Rajkumar Manoharan [this message]
2010-12-13 13:37 ` [PATCH v3 1/8] ath9k_hw: only use the PCIe disable register write sequence for AR5416 Felix Fietkau
2010-12-13 13:46 ` Rajkumar Manoharan
2010-12-13 16:03 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213111207.GA3121@vmraj-lnx.users.atheros.com \
--to=rmanoharan@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox