From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "John Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: remove implicit direct scan
Date: Wed, 29 Oct 2008 01:48:58 +0200 [thread overview]
Message-ID: <1ba2fa240810281648wff91b13ree84f41dd9d6ba2@mail.gmail.com> (raw)
In-Reply-To: <1225234763.1369.3.camel@johannes.berg>
On Wed, Oct 29, 2008 at 12:59 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Tue, 2008-10-28 at 23:54 +0200, Tomas Winkler wrote:
>
>> >> Am I missing something? This seems very strange! What specifies that
>> >> when an SSID is set on an interface the user wants to scan for that one?
>> >> The interface might just have been associated previously to that SSID,
>> >> now disassociated and network manager is asking for a scan to get
>> >> information about networks to let the user select a new one.
>> >
>> > NACK, this is a heuristic that helps connection to configured SSID. It
>> > doesn't mean that other ssid won't be scanned.
>> > This code might be revised again when multiple SSID scan will be implemented
>> > Tomas
>> >
>> Okay I've only now have seen the real reason for this. The SSID
>> removal from the driver API. It's much better argument for removing
>> this code anyway have to think how this will be substituted.
>
> :)
> Unless somebody can come up with a good argument for requiring the SSID?
> I don't see it being necessary the way beaconing and everything is
> designed in mac80211 now, and this leaves only the BSSID in the
> interface config which I'll move to BSS config and then remove the
> interface config thing completely.
>
> Also, doesn't ieee80211_sta_config_auth already do exactly this
> heuristic thing? If it doesn't know about the BSS it'll initiate a scan
> for the SSID it's looking for?
Yep, you are right.
Tomas
>
> johannes
>
prev parent reply other threads:[~2008-10-28 23:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 17:21 [PATCH] iwlwifi: remove implicit direct scan Johannes Berg
2008-10-28 20:53 ` Tomas Winkler
2008-10-28 21:54 ` Tomas Winkler
2008-10-28 22:59 ` Johannes Berg
2008-10-28 23:48 ` Tomas Winkler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240810281648wff91b13ree84f41dd9d6ba2@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox