From: "Tomas Winkler" <tomasw@gmail.com>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Jouni Malinen" <Jouni.Malinen@atheros.com>,
"Luis Rodriguez" <Luis.Rodriguez@atheros.com>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Subject: Re: [PATCH 16/16] mac80211: Add a new event in ieee80211_ampdu_mlme_action
Date: Wed, 29 Oct 2008 11:26:56 +0200 [thread overview]
Message-ID: <1ba2fa240810290226t23bdda5cjf2c4a2716cffa5bb@mail.gmail.com> (raw)
In-Reply-To: <18696.10706.405455.724835@gargle.gargle.HOWL>
On Wed, Oct 29, 2008 at 11:16 AM, Sujith <Sujith.Manoharan@atheros.com> wrote:
> Tomas Winkler wrote:
>> On Wed, Oct 29, 2008 at 6:49 AM, Sujith <Sujith.Manoharan@atheros.com> wrote:
>> > Send a notification to the driver on succesful
>> > reception of an ADDBA response, add IEEE80211_AMPDU_TX_RESUME
>> > for this purpose.
>>
>> What what is wrong with IEEE80211_AMPDU_TX_START ? I don' t understand
>> why this is needed?
>
> On receiving an IEEE80211_AMPDU_TX_START notification, packets destined to
> that TID are stored in a buffer, and to send them out as aggregates, ath9k
> needs to know whether the ADDBA exchange has completed or not.
>
> If the ADDBA request has been declined, IEEE80211_AMPDU_TX_STOP is sent to
> the driver, but no notification is sent if the ADDBA request has been accepted.
Okay this means that we pushing this buffering to driver after all.
Otherwise mac80211 would just trigger the TX on successful ADDBA
Tomas
next prev parent reply other threads:[~2008-10-29 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 4:49 [PATCH 16/16] mac80211: Add a new event in ieee80211_ampdu_mlme_action Sujith
2008-10-29 9:11 ` Tomas Winkler
2008-10-29 9:16 ` Sujith
2008-10-29 9:26 ` Tomas Winkler [this message]
2008-10-29 9:28 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240810290226t23bdda5cjf2c4a2716cffa5bb@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=Jouni.Malinen@atheros.com \
--cc=Luis.Rodriguez@atheros.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox