* [PATCH] rtl8187: remove NICMAC setting in configure_filters callback
@ 2007-10-12 20:45 Michael Wu
2007-10-12 20:53 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Michael Wu @ 2007-10-12 20:45 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless
From: Michael Wu <flamingice@sourmilk.net>
NICMAC should always be set.
Signed-off-by: Michael Wu <flamingice@sourmilk.net>
---
drivers/net/wireless/rtl8187_dev.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/rtl8187_dev.c b/drivers/net/wireless/rtl8187_dev.c
index 643919a..590f4b4 100644
--- a/drivers/net/wireless/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl8187_dev.c
@@ -588,8 +588,6 @@ static void rtl8187_configure_filter(struct ieee80211_hw *dev,
*total_flags = 0;
- if (changed_flags & FIF_PROMISC_IN_BSS)
- priv->rx_conf ^= RTL818X_RX_CONF_NICMAC;
if (changed_flags & FIF_ALLMULTI)
priv->rx_conf ^= RTL818X_RX_CONF_MULTICAST;
if (changed_flags & FIF_FCSFAIL)
@@ -602,8 +600,6 @@ static void rtl8187_configure_filter(struct ieee80211_hw *dev,
if (mc_count > 0)
priv->rx_conf |= RTL818X_RX_CONF_MULTICAST;
- if (priv->rx_conf & RTL818X_RX_CONF_NICMAC)
- *total_flags |= FIF_PROMISC_IN_BSS;
if (priv->rx_conf & RTL818X_RX_CONF_MULTICAST)
*total_flags |= FIF_ALLMULTI;
if (priv->rx_conf & RTL818X_RX_CONF_FCS)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8187: remove NICMAC setting in configure_filters callback
2007-10-12 20:45 [PATCH] rtl8187: remove NICMAC setting in configure_filters callback Michael Wu
@ 2007-10-12 20:53 ` Johannes Berg
2007-10-12 20:59 ` Michael Wu
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2007-10-12 20:53 UTC (permalink / raw)
To: Michael Wu; +Cc: John Linville, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On Fri, 2007-10-12 at 16:45 -0400, Michael Wu wrote:
> @@ -602,8 +600,6 @@ static void rtl8187_configure_filter(struct ieee80211_hw *dev,
> if (mc_count > 0)
> priv->rx_conf |= RTL818X_RX_CONF_MULTICAST;
>
> - if (priv->rx_conf & RTL818X_RX_CONF_NICMAC)
> - *total_flags |= FIF_PROMISC_IN_BSS;
Does this mean you're always operating promiscuously, or was this a bug?
If the latter, do you not support promisc at all? Or should the FIF flag
always be set?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-12 21:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-12 20:45 [PATCH] rtl8187: remove NICMAC setting in configure_filters callback Michael Wu
2007-10-12 20:53 ` Johannes Berg
2007-10-12 20:59 ` Michael Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox