* [PATCH] ssb: Fix build for non-PCIhost
[not found] ` <20080401092119.3cb214b1.randy.dunlap@oracle.com>
@ 2008-04-02 15:03 ` Michael Buesch
2008-04-02 15:33 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Michael Buesch @ 2008-04-02 15:03 UTC (permalink / raw)
To: John Linville
Cc: Randy Dunlap, Stephen Rothwell, linux-next, LKML, bcm43xx-dev,
linux-wireless
This fixes a build error when PCMCIA-host support is built,
but PCI-host support is disabled.
Hell, who on earth would use such a weird configuration. :D
drivers/built-in.o: In function `ssb_attr_sprom_store':
(.text+0x1c4b79): undefined reference to `ssb_devices_freeze'
drivers/built-in.o: In function `ssb_attr_sprom_store':
(.text+0x1c4bb3): undefined reference to `ssb_devices_thaw'
make[1]: *** [.tmp_vmlinux1] Error 1
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
John, please apply this to 2.6.26
Index: wireless-testing/drivers/ssb/main.c
===================================================================
--- wireless-testing.orig/drivers/ssb/main.c 2008-03-21 21:41:31.000000000 +0100
+++ wireless-testing/drivers/ssb/main.c 2008-04-02 16:50:16.000000000 +0200
@@ -202,7 +202,7 @@ out:
return err;
}
-#ifdef CONFIG_SSB_PCIHOST
+#ifdef CONFIG_SSB_SPROM
int ssb_devices_freeze(struct ssb_bus *bus)
{
struct ssb_device *dev;
@@ -288,7 +288,7 @@ int ssb_devices_thaw(struct ssb_bus *bus
return 0;
}
-#endif /* CONFIG_SSB_PCIHOST */
+#endif /* CONFIG_SSB_SPROM */
static void ssb_device_shutdown(struct device *dev)
{
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ssb: Fix build for non-PCIhost
2008-04-02 15:03 ` [PATCH] ssb: Fix build for non-PCIhost Michael Buesch
@ 2008-04-02 15:33 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2008-04-02 15:33 UTC (permalink / raw)
To: Michael Buesch
Cc: John Linville, Stephen Rothwell, linux-next, LKML, bcm43xx-dev,
linux-wireless
On Wed, 2 Apr 2008 17:03:26 +0200 Michael Buesch wrote:
> This fixes a build error when PCMCIA-host support is built,
> but PCI-host support is disabled.
> Hell, who on earth would use such a weird configuration. :D
>
> drivers/built-in.o: In function `ssb_attr_sprom_store':
> (.text+0x1c4b79): undefined reference to `ssb_devices_freeze'
> drivers/built-in.o: In function `ssb_attr_sprom_store':
> (.text+0x1c4bb3): undefined reference to `ssb_devices_thaw'
> make[1]: *** [.tmp_vmlinux1] Error 1
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>
> John, please apply this to 2.6.26
>
>
> Index: wireless-testing/drivers/ssb/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/ssb/main.c 2008-03-21 21:41:31.000000000 +0100
> +++ wireless-testing/drivers/ssb/main.c 2008-04-02 16:50:16.000000000 +0200
> @@ -202,7 +202,7 @@ out:
> return err;
> }
>
> -#ifdef CONFIG_SSB_PCIHOST
> +#ifdef CONFIG_SSB_SPROM
> int ssb_devices_freeze(struct ssb_bus *bus)
> {
> struct ssb_device *dev;
> @@ -288,7 +288,7 @@ int ssb_devices_thaw(struct ssb_bus *bus
>
> return 0;
> }
> -#endif /* CONFIG_SSB_PCIHOST */
> +#endif /* CONFIG_SSB_SPROM */
>
> static void ssb_device_shutdown(struct device *dev)
> {
>
>
> --
---
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-02 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080401175230.9ffe75cf.sfr@canb.auug.org.au>
[not found] ` <20080401092119.3cb214b1.randy.dunlap@oracle.com>
2008-04-02 15:03 ` [PATCH] ssb: Fix build for non-PCIhost Michael Buesch
2008-04-02 15:33 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox