suspend vs. b43

suspend vs. b43

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Hi,

Since a while ago I've had trouble resuming when b43 was connected to an
AP while suspended.

I did a test today where this was the only difference, but I failed to
see whether ssb or b43 were causing the problem.

Does anyone have a machine with b43 in it that can suspend and supports
the RTC-trace feature so we can narrow it down? Even reproducing might
help to make sure it's not just something weird with my powerbook.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: suspend vs. b43

[Michael Buesch]

On Friday 30 May 2008 14:31:53 Johannes Berg wrote:
> Since a while ago I've had trouble resuming when b43 was connected to an
> AP while suspended.
> 
> I did a test today where this was the only difference, but I failed to
> see whether ssb or b43 were causing the problem.
> 
> Does anyone have a machine with b43 in it that can suspend and supports
> the RTC-trace feature so we can narrow it down? Even reproducing might
> help to make sure it's not just something weird with my powerbook.

Resume is pretty broken since some time for me.
It sometimes works fine and sometimes just hangs with a black screen.
I have no idea what's going on.

-- 
Greetings Michael.

Re: suspend vs. b43

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

On Fri, 2008-05-30 at 16:06 +0200, Michael Buesch wrote:
> On Friday 30 May 2008 14:31:53 Johannes Berg wrote:
> > Since a while ago I've had trouble resuming when b43 was connected to an
> > AP while suspended.
> > 
> > I did a test today where this was the only difference, but I failed to
> > see whether ssb or b43 were causing the problem.
> > 
> > Does anyone have a machine with b43 in it that can suspend and supports
> > the RTC-trace feature so we can narrow it down? Even reproducing might
> > help to make sure it's not just something weird with my powerbook.
> 
> Resume is pretty broken since some time for me.
> It sometimes works fine and sometimes just hangs with a black screen.
> I have no idea what's going on.

Odd. Resume itself works just fine here, except when b43 is up. But then
again, you might not notice that this is the problem because by default,
nothing gets printed on the resume console and then it will indeed hang
with a black screen.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: suspend vs. b43

[Michael Buesch]

On Friday 30 May 2008 16:37:18 Johannes Berg wrote:
> Odd. Resume itself works just fine here, except when b43 is up. But then
> again, you might not notice that this is the problem because by default,
> nothing gets printed on the resume console and then it will indeed hang
> with a black screen.

How can I change the printing?

-- 
Greetings Michael.

Re: suspend vs. b43

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Fri, 2008-05-30 at 16:42 +0200, Michael Buesch wrote:
> On Friday 30 May 2008 16:37:18 Johannes Berg wrote:
> > Odd. Resume itself works just fine here, except when b43 is up. But then
> > again, you might not notice that this is the problem because by default,
> > nothing gets printed on the resume console and then it will indeed hang
> > with a black screen.
> 
> How can I change the printing?

Hmm. It seems I might have been wrong here. Rafael, do we still have
console suspend stuff?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: suspend vs. b43

[Rafael J. Wysocki]

On Friday, 30 of May 2008, Johannes Berg wrote:
> On Fri, 2008-05-30 at 16:42 +0200, Michael Buesch wrote:
> > On Friday 30 May 2008 16:37:18 Johannes Berg wrote:
> > > Odd. Resume itself works just fine here, except when b43 is up. But then
> > > again, you might not notice that this is the problem because by default,
> > > nothing gets printed on the resume console and then it will indeed hang
> > > with a black screen.
> > 
> > How can I change the printing?
> 
> Hmm. It seems I might have been wrong here. Rafael, do we still have
> console suspend stuff?

Yes, we do.  Use "no_console_suspend" in the kernel command line to change
that, but note that it's not generally safe (eg. if you are using netconsole at
the same time).

Thanks,
Rafael

Re: suspend vs. b43

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

On Fri, 2008-05-30 at 17:20 +0200, Rafael J. Wysocki wrote:
> On Friday, 30 of May 2008, Johannes Berg wrote:
> > On Fri, 2008-05-30 at 16:42 +0200, Michael Buesch wrote:
> > > On Friday 30 May 2008 16:37:18 Johannes Berg wrote:
> > > > Odd. Resume itself works just fine here, except when b43 is up. But then
> > > > again, you might not notice that this is the problem because by default,
> > > > nothing gets printed on the resume console and then it will indeed hang
> > > > with a black screen.
> > > 
> > > How can I change the printing?
> > 
> > Hmm. It seems I might have been wrong here. Rafael, do we still have
> > console suspend stuff?
> 
> Yes, we do.  Use "no_console_suspend" in the kernel command line to change
> that, but note that it's not generally safe (eg. if you are using netconsole at
> the same time).

I see. System reset hard and clock set to 1904, PMU didn't like me :)

Thing is, I do have no_console_suspend (hardcoded in my boot loader
config so I forgot), but even with PM-debug I didn't see it hang at b43
and no useful messages. Not sure what to do, hence asking if anybody has
the rtc-trace stuff.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: suspend vs. b43

[Rafael J. Wysocki]

On Friday, 30 of May 2008, Johannes Berg wrote:
> On Fri, 2008-05-30 at 17:20 +0200, Rafael J. Wysocki wrote:
> > On Friday, 30 of May 2008, Johannes Berg wrote:
> > > On Fri, 2008-05-30 at 16:42 +0200, Michael Buesch wrote:
> > > > On Friday 30 May 2008 16:37:18 Johannes Berg wrote:
> > > > > Odd. Resume itself works just fine here, except when b43 is up. But then
> > > > > again, you might not notice that this is the problem because by default,
> > > > > nothing gets printed on the resume console and then it will indeed hang
> > > > > with a black screen.
> > > > 
> > > > How can I change the printing?
> > > 
> > > Hmm. It seems I might have been wrong here. Rafael, do we still have
> > > console suspend stuff?
> > 
> > Yes, we do.  Use "no_console_suspend" in the kernel command line to change
> > that, but note that it's not generally safe (eg. if you are using netconsole at
> > the same time).
> 
> I see. System reset hard and clock set to 1904, PMU didn't like me :)
> 
> Thing is, I do have no_console_suspend (hardcoded in my boot loader
> config so I forgot), but even with PM-debug I didn't see it hang at b43
> and no useful messages. Not sure what to do, hence asking if anybody has
> the rtc-trace stuff.

It hangs for me either at read_unlock_irqrestore() in b43_op_tx() or somewhere
in ieee80211_tx() (at various places).

Thanks,
Rafael

Re: suspend vs. b43

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]


> It hangs for me either at read_unlock_irqrestore() in b43_op_tx() or somewhere
> in ieee80211_tx() (at various places).

Huh. Why is it even getting into the tx path? And even then, why does it
hang at an unlock?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: suspend vs. b43

[Rafael J. Wysocki]

On Saturday, 31 of May 2008, Johannes Berg wrote:
> 
> > It hangs for me either at read_unlock_irqrestore() in b43_op_tx() or somewhere
> > in ieee80211_tx() (at various places).
> 
> Huh. Why is it even getting into the tx path? And even then, why does it
> hang at an unlock?

Well, I saw that during hibernation, so it probably happened after creating the
image, when devices were being resumed for image saving.

Thanks,
Rafael

Re: suspend vs. b43

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

On Sat, 2008-05-31 at 00:49 +0200, Rafael J. Wysocki wrote:
> On Saturday, 31 of May 2008, Johannes Berg wrote:
> > 
> > > It hangs for me either at read_unlock_irqrestore() in b43_op_tx() or somewhere
> > > in ieee80211_tx() (at various places).
> > 
> > Huh. Why is it even getting into the tx path? And even then, why does it
> > hang at an unlock?
> 
> Well, I saw that during hibernation, so it probably happened after creating the
> image, when devices were being resumed for image saving.

Yeah, like I said earlier to somebody. Still doesn't make much sense
here. I'll play with it next week, or you could try to put into
suspend() a call to ieee80211_stop_queues() and in resume
ieee80211_wake_queues(), maybe that fixes it? I probably won't have time
over the weekend to look more into it, sorry.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: suspend vs. b43

[Rafael J. Wysocki]

On Saturday, 31 of May 2008, Johannes Berg wrote:
> On Sat, 2008-05-31 at 00:49 +0200, Rafael J. Wysocki wrote:
> > On Saturday, 31 of May 2008, Johannes Berg wrote:
> > > 
> > > > It hangs for me either at read_unlock_irqrestore() in b43_op_tx() or somewhere
> > > > in ieee80211_tx() (at various places).
> > > 
> > > Huh. Why is it even getting into the tx path? And even then, why does it
> > > hang at an unlock?
> > 
> > Well, I saw that during hibernation, so it probably happened after creating the
> > image, when devices were being resumed for image saving.
> 
> Yeah, like I said earlier to somebody. Still doesn't make much sense
> here. I'll play with it next week, or you could try to put into
> suspend() a call to ieee80211_stop_queues() and in resume
> ieee80211_wake_queues(), maybe that fixes it? I probably won't have time
> over the weekend to look more into it, sorry.

No big deal. :-)

It's always been breaking for me like this ...

Thanks,
Rafael

Re: suspend vs. b43

[Holger Schurig]

> Odd. Resume itself works just fine here, except when b43 is
> up. But then again, you might not notice that this is the
> problem because by default, nothing gets printed on the resume
> console and then it will indeed hang with a black screen.

pepper it with printk's and add netconsole ...

Re: suspend vs. b43

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Fri, 2008-05-30 at 16:49 +0200, Holger Schurig wrote:
> > Odd. Resume itself works just fine here, except when b43 is
> > up. But then again, you might not notice that this is the
> > problem because by default, nothing gets printed on the resume
> > console and then it will indeed hang with a black screen.
> 
> pepper it with printk's and add netconsole ...

Well, yeah, netconsole _might_ work as sungem gets resumed before b43,
but I tried doing that on the regular console and didn't see anything
useful.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: suspend vs. b43

[Ehud Gavron]

Johannes Berg wrote:
> On Fri, 2008-05-30 at 16:06 +0200, Michael Buesch wrote:
>   
>> On Friday 30 May 2008 14:31:53 Johannes Berg wrote:
>>     
>>> Since a while ago I've had trouble resuming when b43 was connected to an
>>> AP while suspended.
>>>
>>> I did a test today where this was the only difference, but I failed to
>>> see whether ssb or b43 were causing the problem.
>>>
>>> Does anyone have a machine with b43 in it that can suspend and supports
>>> the RTC-trace feature so we can narrow it down? Even reproducing might
>>> help to make sure it's not just something weird with my powerbook.
>>>       
>> Resume is pretty broken since some time for me.
>> It sometimes works fine and sometimes just hangs with a black screen.
>> I have no idea what's going on.
>>     
>
> Odd. Resume itself works just fine here, except when b43 is up. But then
> again, you might not notice that this is the problem because by default,
> nothing gets printed on the resume console and then it will indeed hang
> with a black screen.
>
> johannes
>   
>   
With NM disabled 2.6.25-wl  4311 after a suspend/resume I can:
1. Successfully scan for APs (ifconfig wlan0 up... iwlist wlan0 scan)
2. Associate with an AP  (iwconfig ...essid...key...)
3. Get a DHCP address (dhclient... offer... bound to address such and such)
but
4. NO FURTHER IP COMMUNICATIONS WORKS

Let me know what other diags to run or if I should upgrade to the latest 
wl tree if you think that will change the symptoms.
Things have been busy but there is a weekend coming up here shortly.

Ehud

> ------------------------------------------------------------------------
>
> _______________________________________________
> Bcm43xx-dev mailing list
> Bcm43xx-dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
>   

Re: suspend vs. b43

[Rafael J. Wysocki]

On Friday, 30 of May 2008, Johannes Berg wrote:
> On Fri, 2008-05-30 at 16:06 +0200, Michael Buesch wrote:
> > On Friday 30 May 2008 14:31:53 Johannes Berg wrote:
> > > Since a while ago I've had trouble resuming when b43 was connected to an
> > > AP while suspended.
> > > 
> > > I did a test today where this was the only difference, but I failed to
> > > see whether ssb or b43 were causing the problem.
> > > 
> > > Does anyone have a machine with b43 in it that can suspend and supports
> > > the RTC-trace feature so we can narrow it down? Even reproducing might
> > > help to make sure it's not just something weird with my powerbook.
> > 
> > Resume is pretty broken since some time for me.
> > It sometimes works fine and sometimes just hangs with a black screen.
> > I have no idea what's going on.
> 
> Odd. Resume itself works just fine here, except when b43 is up.

I can confirm that.  It looks like a deadlock with mac80211 or something
similar to my untrained eye.

> But then again, you might not notice that this is the problem because by
> default, nothing gets printed on the resume console and then it will indeed
> hang with a black screen.

Please use "no_console_suspend", as I said in the other message.

Thanks,
Rafael

Re: suspend vs. b43

[Rafael J. Wysocki]

On Friday, 30 of May 2008, Johannes Berg wrote:
> Hi,

Hi,

> Since a while ago I've had trouble resuming when b43 was connected to an
> AP while suspended.
> 
> I did a test today where this was the only difference, but I failed to
> see whether ssb or b43 were causing the problem.
> 
> Does anyone have a machine with b43 in it that can suspend and supports
> the RTC-trace feature so we can narrow it down? Even reproducing might
> help to make sure it's not just something weird with my powerbook.

No, it's not.  It just doesn't work, AFAICS.

My box is only able to suspend (without hanging) if NetworkManager is switched
off or b43 is unloaded before an attempt to.

Unfortunately, I didn't have the time to fight with that.

Thanks,
Rafael

Re: suspend vs. b43

[Michael Grundmann]

I can reproduce this too on my HP6715s 
(b43-phy2: Broadcom 4311 WLAN found
b43-phy2 debug: Found PHY: Analog 4, Type 2, Revision 9
b43-phy2 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2)
it hangs while hibernating with tuxonice.


> Does anyone have a machine with b43 in it that can suspend and supports
> the RTC-trace feature so we can narrow it down? Even reproducing might
> help to make sure it's not just something weird with my powerbook.

Re: suspend vs. b43

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

On Fri, 2008-05-30 at 16:31 +0200, Michael Grundmann wrote:
> I can reproduce this too on my HP6715s 
> (b43-phy2: Broadcom 4311 WLAN found
> b43-phy2 debug: Found PHY: Analog 4, Type 2, Revision 9
> b43-phy2 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2)
> it hangs while hibernating with tuxonice.

Just a note: this might seem like a different on first sight, but since
hibernation will actually call resume before powerdown it might be the
same.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: suspend vs. b43

[Michael Grundmann]

On Friday 30 May 2008 16:40:38 Johannes Berg wrote:
> On Fri, 2008-05-30 at 16:31 +0200, Michael Grundmann wrote:
> > I can reproduce this too on my HP6715s
> > (b43-phy2: Broadcom 4311 WLAN found
> > b43-phy2 debug: Found PHY: Analog 4, Type 2, Revision 9
> > b43-phy2 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2)
> > it hangs while hibernating with tuxonice.
>
> Just a note: this might seem like a different on first sight, but since
> hibernation will actually call resume before powerdown it might be the
> same.
>
> johannes

It works fine when i unload the b43 before.

Michael