Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] rndis_wlan: handle NL80211_AUTHTYPE_AUTOMATIC
@ 2009-11-16  9:56 Jussi Kivilinna
  2009-11-16 10:22 ` Johannes Berg
  0 siblings, 1 reply; 3+ messages in thread
From: Jussi Kivilinna @ 2009-11-16  9:56 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-wireless

rndis_wlan didn't know about NL80211_AUTHTYPE_AUTOMATIC and simple
setup with 'iwconfig wlan essid no-encrypt' would fail (ENOSUPP).

Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
---

 drivers/net/wireless/rndis_wlan.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index 54175b6..dfc61fd 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -1070,7 +1070,8 @@ static int set_auth_mode(struct usbnet *usbdev, u32 wpa_version,
 			auth_mode = NDIS_80211_AUTH_WPA_NONE;
 	} else if (auth_type == NL80211_AUTHTYPE_SHARED_KEY)
 		auth_mode = NDIS_80211_AUTH_SHARED;
-	else if (auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM)
+	else if (auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM ||
+			auth_type == NL80211_AUTHTYPE_AUTOMATIC)
 		auth_mode = NDIS_80211_AUTH_OPEN;
 	else
 		return -ENOTSUPP;


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] rndis_wlan: handle NL80211_AUTHTYPE_AUTOMATIC
  2009-11-16  9:56 [PATCH] rndis_wlan: handle NL80211_AUTHTYPE_AUTOMATIC Jussi Kivilinna
@ 2009-11-16 10:22 ` Johannes Berg
  2009-11-16 10:43   ` Jussi Kivilinna
  0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2009-11-16 10:22 UTC (permalink / raw)
  To: Jussi Kivilinna; +Cc: John W. Linville, linux-wireless

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On Mon, 2009-11-16 at 11:56 +0200, Jussi Kivilinna wrote:
> rndis_wlan didn't know about NL80211_AUTHTYPE_AUTOMATIC and simple
> setup with 'iwconfig wlan essid no-encrypt' would fail (ENOSUPP).
> 
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
> ---
> 
>  drivers/net/wireless/rndis_wlan.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
> index 54175b6..dfc61fd 100644
> --- a/drivers/net/wireless/rndis_wlan.c
> +++ b/drivers/net/wireless/rndis_wlan.c
> @@ -1070,7 +1070,8 @@ static int set_auth_mode(struct usbnet *usbdev, u32 wpa_version,
>  			auth_mode = NDIS_80211_AUTH_WPA_NONE;
>  	} else if (auth_type == NL80211_AUTHTYPE_SHARED_KEY)
>  		auth_mode = NDIS_80211_AUTH_SHARED;
> -	else if (auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM)
> +	else if (auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM ||
> +			auth_type == NL80211_AUTHTYPE_AUTOMATIC)
>  		auth_mode = NDIS_80211_AUTH_OPEN;

Will that try open and shared though?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rndis_wlan: handle NL80211_AUTHTYPE_AUTOMATIC
  2009-11-16 10:22 ` Johannes Berg
@ 2009-11-16 10:43   ` Jussi Kivilinna
  0 siblings, 0 replies; 3+ messages in thread
From: Jussi Kivilinna @ 2009-11-16 10:43 UTC (permalink / raw)
  To: Johannes Berg; +Cc: John W. Linville, linux-wireless

Quoting "Johannes Berg" <johannes@sipsolutions.net>:

>
> Will that try open and shared though?
>

No, I'll post v2 which uses NDIS_80211_AUTH_AUTO_SWITCH instead.

-jussi


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-11-16 10:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-16  9:56 [PATCH] rndis_wlan: handle NL80211_AUTHTYPE_AUTOMATIC Jussi Kivilinna
2009-11-16 10:22 ` Johannes Berg
2009-11-16 10:43   ` Jussi Kivilinna

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox