Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes.berg@intel.com>,
	Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 10/11] iwlwifi: mvm: remove superfluous flush_work()
Date: Sat, 25 Nov 2017 18:34:43 +0200	[thread overview]
Message-ID: <20171125163444.24258-11-luca@coelho.fi> (raw)
In-Reply-To: <20171125163444.24258-1-luca@coelho.fi>

From: Johannes Berg <johannes.berg@intel.com>

Since iwl_mvm_start_p2p_roc() is only called from iwl_mvm_roc(),
which already flushes the same work item, doing it again in it
is superfluous. Remove it and move the comment to the first one.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c   | 4 ++++
 drivers/net/wireless/intel/iwlwifi/mvm/time-event.c | 6 ------
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 149d301e5e98..e0226d2315bb 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -3192,6 +3192,10 @@ static int iwl_mvm_roc(struct ieee80211_hw *hw,
 	IWL_DEBUG_MAC80211(mvm, "enter (%d, %d, %d)\n", channel->hw_value,
 			   duration, type);
 
+	/*
+	 * Flush the done work, just in case it's still pending, so that
+	 * the work it does can complete and we can accept new frames.
+	 */
 	flush_work(&mvm->roc_done_wk);
 
 	mutex_lock(&mvm->mutex);
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/time-event.c b/drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
index 4d0314912e94..d3b8cb1e20b6 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
@@ -759,12 +759,6 @@ int iwl_mvm_start_p2p_roc(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
 		return -EBUSY;
 	}
 
-	/*
-	 * Flush the done work, just in case it's still pending, so that
-	 * the work it does can complete and we can accept new frames.
-	 */
-	flush_work(&mvm->roc_done_wk);
-
 	time_cmd.action = cpu_to_le32(FW_CTXT_ACTION_ADD);
 	time_cmd.id_and_color =
 		cpu_to_le32(FW_CMD_ID_AND_COLOR(mvmvif->id, mvmvif->color));
-- 
2.15.0

  parent reply	other threads:[~2017-11-25 16:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-25 16:34 [PATCH 00/11] iwlwifi: updates intended for v4.16 2017-11-25 Luca Coelho
2017-11-25 16:34 ` [PATCH 01/11] iwlwifi: mvm: check for short GI only for OFDM Luca Coelho
2017-11-25 16:34 ` [PATCH 02/11] iwlwifi: mvm: support MGMT frames in compressed BA Luca Coelho
2017-11-25 16:34 ` [PATCH 03/11] iwlwifi: mvm: rs: don't override the rate history in the search cycle Luca Coelho
2017-11-25 16:34 ` [PATCH 04/11] iwlwifi: mvm: revert support new Coex firmware API Luca Coelho
2017-11-25 16:34 ` [PATCH 05/11] iwlwifi: mvm: remove TCP wakeup support Luca Coelho
2017-11-25 16:34 ` [PATCH 06/11] iwlwifi: print the version number of the firmware in hex Luca Coelho
2017-11-25 16:34 ` [PATCH 07/11] iwlwifi: dbg: allow wrt collection before ALIVE Luca Coelho
2017-11-25 16:34 ` [PATCH 08/11] iwlwifi: mvm: Add debugfs support for FTM initiator fields Luca Coelho
2017-11-28 13:34   ` kbuild test robot
2017-11-28 14:39     ` Luciano Coelho
2017-11-25 16:34 ` [PATCH 09/11] iwlwifi: fix the ALIVE notification layout Luca Coelho
2017-11-25 16:34 ` Luca Coelho [this message]
2017-11-25 16:34 ` [PATCH 11/11] iwlwifi: rename the temporary name of A000 to the official 22000 Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171125163444.24258-11-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=johannes.berg@intel.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox