Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
	Liad Kaufman <liad.kaufman@intel.com>,
	Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 02/11] iwlwifi: mvm: support MGMT frames in compressed BA
Date: Sat, 25 Nov 2017 18:34:35 +0200	[thread overview]
Message-ID: <20171125163444.24258-3-luca@coelho.fi> (raw)
In-Reply-To: <20171125163444.24258-1-luca@coelho.fi>

From: Liad Kaufman <liad.kaufman@intel.com>

In A000 family, compressed BA notifs can include MGMT
frames, so don't fail RXs in such a case.

While at it, since in A000 the TID for MGMT frames is
15, treat it in the RX flow as if received TID 8. This
way we won't require special handling of this TID.

Signed-off-by: Liad Kaufman <liad.kaufman@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
index d88c3685a6dd..0407ea30bb82 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
@@ -1623,7 +1623,7 @@ static void iwl_mvm_tx_reclaim(struct iwl_mvm *mvm, int sta_id, int tid,
 	int freed;
 
 	if (WARN_ONCE(sta_id >= IWL_MVM_STATION_COUNT ||
-		      tid >= IWL_MAX_TID_COUNT,
+		      tid > IWL_MAX_TID_COUNT,
 		      "sta_id %d tid %d", sta_id, tid))
 		return;
 
@@ -1678,7 +1678,7 @@ static void iwl_mvm_tx_reclaim(struct iwl_mvm *mvm, int sta_id, int tid,
 		if (ieee80211_is_data_qos(hdr->frame_control))
 			freed++;
 		else
-			WARN_ON_ONCE(1);
+			WARN_ON_ONCE(tid != IWL_MAX_TID_COUNT);
 
 		iwl_trans_free_tx_cmd(mvm->trans, info->driver_data[1]);
 
@@ -1770,8 +1770,12 @@ void iwl_mvm_rx_ba_notif(struct iwl_mvm *mvm, struct iwl_rx_cmd_buffer *rxb)
 			struct iwl_mvm_compressed_ba_tfd *ba_tfd =
 				&ba_res->tfd[i];
 
+			tid = ba_tfd->tid;
+			if (tid == IWL_MGMT_TID)
+				tid = IWL_MAX_TID_COUNT;
+
 			mvmsta->tid_data[i].lq_color = lq_color;
-			iwl_mvm_tx_reclaim(mvm, sta_id, ba_tfd->tid,
+			iwl_mvm_tx_reclaim(mvm, sta_id, tid,
 					   (int)(le16_to_cpu(ba_tfd->q_num)),
 					   le16_to_cpu(ba_tfd->tfd_index),
 					   &ba_info,
-- 
2.15.0

  parent reply	other threads:[~2017-11-25 16:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-25 16:34 [PATCH 00/11] iwlwifi: updates intended for v4.16 2017-11-25 Luca Coelho
2017-11-25 16:34 ` [PATCH 01/11] iwlwifi: mvm: check for short GI only for OFDM Luca Coelho
2017-11-25 16:34 ` Luca Coelho [this message]
2017-11-25 16:34 ` [PATCH 03/11] iwlwifi: mvm: rs: don't override the rate history in the search cycle Luca Coelho
2017-11-25 16:34 ` [PATCH 04/11] iwlwifi: mvm: revert support new Coex firmware API Luca Coelho
2017-11-25 16:34 ` [PATCH 05/11] iwlwifi: mvm: remove TCP wakeup support Luca Coelho
2017-11-25 16:34 ` [PATCH 06/11] iwlwifi: print the version number of the firmware in hex Luca Coelho
2017-11-25 16:34 ` [PATCH 07/11] iwlwifi: dbg: allow wrt collection before ALIVE Luca Coelho
2017-11-25 16:34 ` [PATCH 08/11] iwlwifi: mvm: Add debugfs support for FTM initiator fields Luca Coelho
2017-11-28 13:34   ` kbuild test robot
2017-11-28 14:39     ` Luciano Coelho
2017-11-25 16:34 ` [PATCH 09/11] iwlwifi: fix the ALIVE notification layout Luca Coelho
2017-11-25 16:34 ` [PATCH 10/11] iwlwifi: mvm: remove superfluous flush_work() Luca Coelho
2017-11-25 16:34 ` [PATCH 11/11] iwlwifi: rename the temporary name of A000 to the official 22000 Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171125163444.24258-3-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=liad.kaufman@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox