From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 06/11] iwlwifi: print the version number of the firmware in hex
Date: Sat, 25 Nov 2017 18:34:39 +0200 [thread overview]
Message-ID: <20171125163444.24258-7-luca@coelho.fi> (raw)
In-Reply-To: <20171125163444.24258-1-luca@coelho.fi>
From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Starting from a version 35, the minor version should be
printed in hexa.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index 4b224d7d967c..de8f6ae2f51b 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -919,9 +919,14 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv,
minor = le32_to_cpup(ptr++);
local_comp = le32_to_cpup(ptr);
- snprintf(drv->fw.fw_version,
- sizeof(drv->fw.fw_version), "%u.%u.%u",
- major, minor, local_comp);
+ if (major >= 35)
+ snprintf(drv->fw.fw_version,
+ sizeof(drv->fw.fw_version),
+ "%u.%08x.%u", major, minor, local_comp);
+ else
+ snprintf(drv->fw.fw_version,
+ sizeof(drv->fw.fw_version),
+ "%u.%u.%u", major, minor, local_comp);
break;
}
case IWL_UCODE_TLV_FW_DBG_DEST: {
--
2.15.0
next prev parent reply other threads:[~2017-11-25 16:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 16:34 [PATCH 00/11] iwlwifi: updates intended for v4.16 2017-11-25 Luca Coelho
2017-11-25 16:34 ` [PATCH 01/11] iwlwifi: mvm: check for short GI only for OFDM Luca Coelho
2017-11-25 16:34 ` [PATCH 02/11] iwlwifi: mvm: support MGMT frames in compressed BA Luca Coelho
2017-11-25 16:34 ` [PATCH 03/11] iwlwifi: mvm: rs: don't override the rate history in the search cycle Luca Coelho
2017-11-25 16:34 ` [PATCH 04/11] iwlwifi: mvm: revert support new Coex firmware API Luca Coelho
2017-11-25 16:34 ` [PATCH 05/11] iwlwifi: mvm: remove TCP wakeup support Luca Coelho
2017-11-25 16:34 ` Luca Coelho [this message]
2017-11-25 16:34 ` [PATCH 07/11] iwlwifi: dbg: allow wrt collection before ALIVE Luca Coelho
2017-11-25 16:34 ` [PATCH 08/11] iwlwifi: mvm: Add debugfs support for FTM initiator fields Luca Coelho
2017-11-28 13:34 ` kbuild test robot
2017-11-28 14:39 ` Luciano Coelho
2017-11-25 16:34 ` [PATCH 09/11] iwlwifi: fix the ALIVE notification layout Luca Coelho
2017-11-25 16:34 ` [PATCH 10/11] iwlwifi: mvm: remove superfluous flush_work() Luca Coelho
2017-11-25 16:34 ` [PATCH 11/11] iwlwifi: rename the temporary name of A000 to the official 22000 Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171125163444.24258-7-luca@coelho.fi \
--to=luca@coelho.fi \
--cc=emmanuel.grumbach@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox