* [PATCH] mt76: mt7921: use correct iftype data on 6GHz cap init
@ 2021-11-26 16:53 Shayne Chen
2021-11-27 14:43 ` Lorenzo Bianconi
0 siblings, 1 reply; 2+ messages in thread
From: Shayne Chen @ 2021-11-26 16:53 UTC (permalink / raw)
To: Felix Fietkau
Cc: linux-wireless, Lorenzo Bianconi, Ryder Lee, Deren Wu,
Evelyn Tsai, linux-mediatek, Shayne Chen
Set 6GHz cap to iftype data which is matched to the type of
current interface.
Fixes: 50ac15a511e3 ("mt76: mt7921: add 6GHz support")
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/mt7921/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
index 5a64126..5540b2d 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
@@ -178,7 +178,7 @@ mt7921_init_he_caps(struct mt7921_phy *phy, enum nl80211_band band,
if (vht_cap->cap & IEEE80211_VHT_CAP_RX_ANTENNA_PATTERN)
cap |= IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS;
- data->he_6ghz_capa.capa = cpu_to_le16(cap);
+ data[idx].he_6ghz_capa.capa = cpu_to_le16(cap);
}
idx++;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mt76: mt7921: use correct iftype data on 6GHz cap init
2021-11-26 16:53 [PATCH] mt76: mt7921: use correct iftype data on 6GHz cap init Shayne Chen
@ 2021-11-27 14:43 ` Lorenzo Bianconi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Bianconi @ 2021-11-27 14:43 UTC (permalink / raw)
To: Shayne Chen
Cc: Felix Fietkau, linux-wireless, Ryder Lee, Deren Wu, Evelyn Tsai,
linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
> Set 6GHz cap to iftype data which is matched to the type of
> current interface.
In this case data points to data[idx] since mt7921 supports just
NL80211_IFTYPE_STATION (please note idx = 0 and idx != i).
Anyway this can be an issue in the future when we will add more vif_type.
Maybe we can drop Fixes tag, not sure. Anyway:
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> Fixes: 50ac15a511e3 ("mt76: mt7921: add 6GHz support")
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> index 5a64126..5540b2d 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> @@ -178,7 +178,7 @@ mt7921_init_he_caps(struct mt7921_phy *phy, enum nl80211_band band,
> if (vht_cap->cap & IEEE80211_VHT_CAP_RX_ANTENNA_PATTERN)
> cap |= IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS;
>
> - data->he_6ghz_capa.capa = cpu_to_le16(cap);
> + data[idx].he_6ghz_capa.capa = cpu_to_le16(cap);
> }
> idx++;
> }
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-27 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-26 16:53 [PATCH] mt76: mt7921: use correct iftype data on 6GHz cap init Shayne Chen
2021-11-27 14:43 ` Lorenzo Bianconi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox