[PATCH] wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

[PATCH] wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

[Zenm Chen]

Add two more USB IDs found in
https://github.com/RinCat/RTL88x2BU-Linux-Driver
to support Mercusys MA30N and D-Link DWA-T185 rev. A1.

Signed-off-by: Zenm Chen <zenmchen@gmail.com>
---
Related discussions:
https://github.com/RinCat/RTL88x2BU-Linux-Driver/issues/237
https://github.com/RinCat/RTL88x2BU-Linux-Driver/issues/146
---
 drivers/net/wireless/realtek/rtw88/rtw8822bu.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
index 8883300fc6ad..572d1f31832e 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
@@ -73,6 +73,10 @@ static const struct usb_device_id rtw_8822bu_id_table[] = {
 	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* ELECOM WDB-867DU3S */
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x0107, 0xff, 0xff, 0xff),
 	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30H */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x010a, 0xff, 0xff, 0xff),
+	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30N */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x3322, 0xff, 0xff, 0xff),
+	  .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* D-Link DWA-T185 rev. A1 */
 	{},
 };
 MODULE_DEVICE_TABLE(usb, rtw_8822bu_id_table);
-- 
2.48.1

RE: [PATCH] wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

[Ping-Ke Shih]

Zenm Chen <zenmchen@gmail.com> wrote:
> Add two more USB IDs found in
> https://github.com/RinCat/RTL88x2BU-Linux-Driver
> to support Mercusys MA30N and D-Link DWA-T185 rev. A1.
> 
> Signed-off-by: Zenm Chen <zenmchen@gmail.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> Related discussions:
> https://github.com/RinCat/RTL88x2BU-Linux-Driver/issues/237
> https://github.com/RinCat/RTL88x2BU-Linux-Driver/issues/146
> ---
>  drivers/net/wireless/realtek/rtw88/rtw8822bu.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
> b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
> index 8883300fc6ad..572d1f31832e 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822bu.c
> @@ -73,6 +73,10 @@ static const struct usb_device_id rtw_8822bu_id_table[] = {
>           .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* ELECOM WDB-867DU3S */
>         { USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x0107, 0xff, 0xff, 0xff),
>           .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30H */
> +       { USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x010a, 0xff, 0xff, 0xff),
> +         .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* Mercusys MA30N */
> +       { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x3322, 0xff, 0xff, 0xff),
> +         .driver_info = (kernel_ulong_t)&(rtw8822b_hw_spec) }, /* D-Link DWA-T185 rev. A1 */

By the way, these IDs aren't in increasing order, how did you pick IDs
from vendor driver?

Not sure if it's worth to sort these IDs so that it would be easier to
align IDs with vendor driver (it should be sorted as well). 

RE: [PATCH] wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

[Zenm Chen]

> By the way, these IDs aren't in increasing order, how did you pick IDs
> from vendor driver?

Mikhail Novosyolov taught me a good command [1] to find out the missing
USB IDs. :)

$ diff -u --color \
<(modinfo a.ko | grep ^alias | sort -u) \
<(modinfo b.ko | grep ^alias | sort -u)

[1] https://github.com/morrownr/88x2bu-20210702/issues/224#issuecomment-2404823387

> Not sure if it's worth to sort these IDs so that it would be easier to
> align IDs with vendor driver (it should be sorted as well).

okay, I will send another patch to sort them after this is merged.

RE: [PATCH] wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

[Ping-Ke Shih]

> > By the way, these IDs aren't in increasing order, how did you pick IDs
> > from vendor driver?
> 
> Mikhail Novosyolov taught me a good command [1] to find out the missing
> USB IDs. :)
> 
> $ diff -u --color \
> <(modinfo a.ko | grep ^alias | sort -u) \
> <(modinfo b.ko | grep ^alias | sort -u)
> 
> [1] https://github.com/morrownr/88x2bu-20210702/issues/224#issuecomment-2404823387
> 

Cool. I thought you compared them with source code rather than binary code. 
So maybe it is not necessary to align them in source code. 

Re: [PATCH] wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

[Ping-Ke Shih]

Zenm Chen <zenmchen@gmail.com> wrote:

> Add two more USB IDs found in
> https://github.com/RinCat/RTL88x2BU-Linux-Driver
> to support Mercusys MA30N and D-Link DWA-T185 rev. A1.
> 
> Signed-off-by: Zenm Chen <zenmchen@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

80c4668d024f wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1

---
https://github.com/pkshih/rtw.git