From: Maxin John <maxin.john@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net
Subject: [PATCH v2] iw: Makefile: support out-of-tree builds
Date: Thu, 30 Apr 2026 00:08:08 +0300 [thread overview]
Message-ID: <20260429210808.1497335-1-maxin.john@gmail.com> (raw)
Enable out-of-tree builds for external frameworks like OpenEmbedded,
so the build can run from a separate directory without changing the source tree.
Supports kernel-style out-of-tree builds using: make O=<builddir>
Signed-off-by: Maxin John <maxin.john@gmail.com>
---
Changes in v2:
- Add support for kernel-style out-of-tree builds using:
make O=<builddir>
- Make SRCDIR computation whitespace-safe by switching to realpath
- Remove ambiguous use of "-I." from CPPFLAGS
---
Makefile | 38 ++++++++++++++++++++++++++++++++------
1 file changed, 32 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 2652fac4e6ee..91961650269d 100644
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,29 @@
MAKEFLAGS += --no-print-directory
+# Support building in a separate output directory (O): 'make O=<builddir>'
+SRCDIR := $(realpath $(dir $(lastword $(MAKEFILE_LIST))))
+
+ifneq ($(O),)
+$(shell mkdir -p "$(O)")
+BUILDDIR := $(realpath $(O))
+$(if $(BUILDDIR),,$(error failed to create output directory "$(O)"))
+endif
+
+ifneq ($(words $(subst :, ,$(SRCDIR))),1)
+$(error source path cannot contain spaces or colons: $(SRCDIR))
+endif
+
+ifneq ($(O),)
+_goals := $(or $(MAKECMDGOALS),all)
+.PHONY: sub-make $(_goals)
+$(_goals): sub-make
+ @:
+sub-make:
+ +@$(MAKE) -C $(BUILDDIR) -f $(SRCDIR)/Makefile O= $(_goals)
+else
+VPATH := $(SRCDIR)
+.PHONY: all check clean install
+
PREFIX ?= /usr
SBINDIR ?= $(PREFIX)/sbin
MANDIR ?= $(PREFIX)/share/man
@@ -20,8 +44,9 @@ CFLAGS += -Wdeclaration-after-statement
CFLAGS += -D__SANE_USERSPACE_TYPES__
CFLAGS += $(CFLAGS_EVAL)
CFLAGS += $(EXTRA_CFLAGS)
+CPPFLAGS += -I$(CURDIR) -I$(SRCDIR)
-_OBJS := $(sort $(patsubst %.c,%.o,$(wildcard *.c)))
+_OBJS := $(sort $(patsubst $(SRCDIR)/%.c,%.o,$(wildcard $(SRCDIR)/*.c)))
VERSION_OBJS := $(filter-out version.o, $(_OBJS))
OBJS := $(VERSION_OBJS) version.o
@@ -93,13 +118,13 @@ endif
all: $(ALL)
version.c: version.sh $(patsubst %.o,%.c,$(VERSION_OBJS)) nl80211.h iw.h Makefile \
- $(wildcard .git/index .git/refs/tags)
+ $(wildcard $(SRCDIR)/.git/index $(SRCDIR)/.git/refs/tags)
@$(NQ) ' GEN ' $@
- $(Q)./version.sh $@
+ $(Q)$(SRCDIR)/version.sh $@
-nl80211-commands.inc: nl80211.h
+nl80211-commands.inc: $(SRCDIR)/nl80211.h
@$(NQ) ' GEN ' $@
- $(Q)sed 's%^\tNL80211_CMD_%%;t n;d;:n s%^\([^=]*\),.*%\t[NL80211_CMD_\1] = \"\L\1\",%;t;d' nl80211.h | grep -v "reserved" > $@
+ $(Q)sed 's%^\tNL80211_CMD_%%;t n;d;:n s%^\([^=]*\),.*%\t[NL80211_CMD_\1] = \"\L\1\",%;t;d' $< | grep -v "reserved" > $@
%.o: %.c iw.h nl80211.h nl80211-commands.inc
@$(NQ) ' CC ' $@
@@ -112,7 +137,7 @@ iw: $(OBJS)
endif
check:
- $(Q)$(MAKE) all CC="REAL_CC=$(CC) CHECK=\"sparse -Wall\" cgcc"
+ $(Q)$(MAKE) -f $(SRCDIR)/Makefile all CC="REAL_CC=$(CC) CHECK=\"sparse -Wall\" cgcc"
%.gz: %
@$(NQ) ' GZIP' $<
@@ -128,3 +153,4 @@ install: iw iw.8.gz
clean:
$(Q)rm -f iw *.o *~ *.gz version.c *-stamp nl80211-commands.inc
+endif
--
2.47.3
next reply other threads:[~2026-04-29 21:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 21:08 Maxin John [this message]
2026-05-05 10:35 ` [PATCH v2] iw: Makefile: support out-of-tree builds Johannes Berg
2026-05-06 20:23 ` Maxin John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429210808.1497335-1-maxin.john@gmail.com \
--to=maxin.john@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox