Re: [PATCH v2] iw: Makefile: support out-of-tree builds

[Maxin John <maxin.john@gmail.com>]

Hi,

On Tue, May 05, 2026 at 12:35:16PM +0200, Johannes Berg wrote:
> On Thu, 2026-04-30 at 00:08 +0300, Maxin John wrote:
> 
> 
> >   - Add support for kernel-style out-of-tree builds using:
> >       make O=<builddir>
> >   - Make SRCDIR computation whitespace-safe by switching to realpath
> >   - Remove ambiguous use of "-I." from CPPFLAGS
> 
> Thanks for fixing that.
> 
> Right now I don't really see _why_ it doesn't work, but it seems
> confusing that if you build in-tree first and then try to build out-of-
> tree, it just says
> 
> 	make[1]: Nothing to be done for 'all'.
> 
> Maybe that should abort? Or work?

Thanks for sharing this observation. Yes, this is not ideal. I will update that
part based on your suggestion.

> It seems that removing VPATH and changing the %.o rule
> 
> -%.o: %.c iw.h nl80211.h nl80211-commands.inc
> +%.o: $(SRCDIR)/%.c $(SRCDIR)/iw.h $(SRCDIR)/nl80211.h nl80211-commands.inc
> 
> makes that work?
> 
> I'll leave it to you though.

I will send a v3 to fix it.
 
> johannes

Best Regards,
Maxin