From: Johannes Berg <johannes@sipsolutions.net>
To: Maxin John <maxin.john@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] iw: Makefile: support out-of-tree builds
Date: Tue, 05 May 2026 12:35:16 +0200 [thread overview]
Message-ID: <6d1b6079bd0c0318e4311bc41a35fc2169a0b4e8.camel@sipsolutions.net> (raw)
In-Reply-To: <20260429210808.1497335-1-maxin.john@gmail.com> (sfid-20260429_230814_067623_F99A536D)
On Thu, 2026-04-30 at 00:08 +0300, Maxin John wrote:
> - Add support for kernel-style out-of-tree builds using:
> make O=<builddir>
> - Make SRCDIR computation whitespace-safe by switching to realpath
> - Remove ambiguous use of "-I." from CPPFLAGS
Thanks for fixing that.
Right now I don't really see _why_ it doesn't work, but it seems
confusing that if you build in-tree first and then try to build out-of-
tree, it just says
make[1]: Nothing to be done for 'all'.
Maybe that should abort? Or work?
It seems that removing VPATH and changing the %.o rule
-%.o: %.c iw.h nl80211.h nl80211-commands.inc
+%.o: $(SRCDIR)/%.c $(SRCDIR)/iw.h $(SRCDIR)/nl80211.h nl80211-commands.inc
makes that work?
I'll leave it to you though.
johannes
next prev parent reply other threads:[~2026-05-05 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 21:08 [PATCH v2] iw: Makefile: support out-of-tree builds Maxin John
2026-05-05 10:35 ` Johannes Berg [this message]
2026-05-06 20:23 ` Maxin John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1b6079bd0c0318e4311bc41a35fc2169a0b4e8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=maxin.john@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox