* [PATCH ath-next] wifi: ath12k: use hal_rx_mon_status for PPDU parse result
@ 2026-10-16 5:49 Kang Yang
2026-10-26 5:56 ` Baochen Qiang
2026-10-26 6:00 ` Vasanthakumar Thiagarajan
0 siblings, 2 replies; 3+ messages in thread
From: Kang Yang @ 2026-10-16 5:49 UTC (permalink / raw)
To: ath12k; +Cc: linux-wireless, Kang Yang
ath12k_wifi7_dp_mon_parse_rx_dest() returns enum
hal_rx_mon_status, but one caller still checks the result against
HAL_TLV_STATUS_PPDU_DONE.
Use HAL_RX_MON_STATUS_PPDU_DONE instead. This is a cleanup only
since both values are identical.
Remove the now unused HAL_TLV_STATUS_* defines.
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
Signed-off-by: Kang Yang <kang.yang@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c | 2 +-
drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h | 5 -----
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c b/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
index 1e29c13ad66d..7d29b49e8a54 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
@@ -3214,7 +3214,7 @@ __ath12k_wifi7_dp_mon_process_ring(struct ath12k *ar, int mac_id,
hal_status = ath12k_wifi7_dp_mon_parse_rx_dest(&ar->dp, pmon, skb);
- if (hal_status == HAL_TLV_STATUS_PPDU_DONE) {
+ if (hal_status == HAL_RX_MON_STATUS_PPDU_DONE) {
ppdu_info->ppdu_continuation = false;
if (ar->monitor_started &&
pmon->mon_ppdu_status == DP_PPDU_STATUS_START) {
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h b/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h
index dd60626b3240..3d7694c22774 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h
+++ b/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h
@@ -41,11 +41,6 @@ struct hal_rx_mon_status_tlv_hdr {
u8 value[];
};
-#define HAL_TLV_STATUS_PPDU_NOT_DONE 0
-#define HAL_TLV_STATUS_PPDU_DONE 1
-#define HAL_TLV_STATUS_BUF_DONE 2
-#define HAL_TLV_STATUS_PPDU_NON_STD_DONE 3
-
enum hal_rx_mon_status {
HAL_RX_MON_STATUS_PPDU_NOT_DONE,
HAL_RX_MON_STATUS_PPDU_DONE,
---
base-commit: cd026e68fdbf88b9cc522b76c7a9d92c9a41f709
change-id: 20261015-hal_rx_mon_status-7e162ff7a9a2
Best regards,
--
Kang Yang <kang.yang@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: use hal_rx_mon_status for PPDU parse result
2026-10-16 5:49 [PATCH ath-next] wifi: ath12k: use hal_rx_mon_status for PPDU parse result Kang Yang
@ 2026-10-26 5:56 ` Baochen Qiang
2026-10-26 6:00 ` Vasanthakumar Thiagarajan
1 sibling, 0 replies; 3+ messages in thread
From: Baochen Qiang @ 2026-10-26 5:56 UTC (permalink / raw)
To: Kang Yang, ath12k; +Cc: linux-wireless
On 10/16/2026 1:49 PM, Kang Yang wrote:
> ath12k_wifi7_dp_mon_parse_rx_dest() returns enum
> hal_rx_mon_status, but one caller still checks the result against
> HAL_TLV_STATUS_PPDU_DONE.
>
> Use HAL_RX_MON_STATUS_PPDU_DONE instead. This is a cleanup only
> since both values are identical.
>
> Remove the now unused HAL_TLV_STATUS_* defines.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>
> Signed-off-by: Kang Yang <kang.yang@oss.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c | 2 +-
> drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h | 5 -----
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c b/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
> index 1e29c13ad66d..7d29b49e8a54 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
> @@ -3214,7 +3214,7 @@ __ath12k_wifi7_dp_mon_process_ring(struct ath12k *ar, int mac_id,
>
> hal_status = ath12k_wifi7_dp_mon_parse_rx_dest(&ar->dp, pmon, skb);
>
> - if (hal_status == HAL_TLV_STATUS_PPDU_DONE) {
> + if (hal_status == HAL_RX_MON_STATUS_PPDU_DONE) {
Not part of this diff, but the same topic:
ath12k_wifi7_dp_mon_srng_process() still declares "u32 hal_status" and
stores the enum hal_rx_mon_status returned by
ath12k_wifi7_dp_mon_rx_parse_mon_status() in it. If you respin for any
reason, better to have it fixed as well.
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: use hal_rx_mon_status for PPDU parse result
2026-10-16 5:49 [PATCH ath-next] wifi: ath12k: use hal_rx_mon_status for PPDU parse result Kang Yang
2026-10-26 5:56 ` Baochen Qiang
@ 2026-10-26 6:00 ` Vasanthakumar Thiagarajan
1 sibling, 0 replies; 3+ messages in thread
From: Vasanthakumar Thiagarajan @ 2026-10-26 6:00 UTC (permalink / raw)
To: Kang Yang, ath12k; +Cc: linux-wireless
On 16-10-2026 11:19, Kang Yang wrote:
> ath12k_wifi7_dp_mon_parse_rx_dest() returns enum
> hal_rx_mon_status, but one caller still checks the result against
> HAL_TLV_STATUS_PPDU_DONE.
>
> Use HAL_RX_MON_STATUS_PPDU_DONE instead. This is a cleanup only
> since both values are identical.
>
> Remove the now unused HAL_TLV_STATUS_* defines.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>
> Signed-off-by: Kang Yang <kang.yang@oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-26 6:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-16 5:49 [PATCH ath-next] wifi: ath12k: use hal_rx_mon_status for PPDU parse result Kang Yang
2026-10-26 5:56 ` Baochen Qiang
2026-10-26 6:00 ` Vasanthakumar Thiagarajan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox