Re: [RFT v9] rfkill: rewrite

[Will Keaney <keaneyw@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]

Johannes Berg wrote:
> This patch completely rewrites the rfkill core to address
> the following deficiencies:
>
>  * all rfkill drivers need to implement polling where necessary
>    rather than having one central implementation
>
>  * updating the rfkill state cannot be done from arbitrary
>    contexts, forcing drivers to use schedule_work and requiring
>    lots of code
>
>  * rfkill drivers need to keep track of soft/hard blocked
>    internally -- the core should do this
>
>  * the rfkill API has many unexpected quirks, for example being
>    asymmetric wrt. alloc/free and register/unregister
>
>  * rfkill can call back into a driver from within a function the
>    driver called -- this is prone to deadlocks and generally
>    should be avoided
>
>  * rfkill-input pointlessly is a separate module
>   
Please leave rfkill-input available as a module, at least until the bug
I reported in my previous e-mail 'Soft Lockup With rfkill_input and
thinkpad_acpi' is resolved.  Otherwise it will render Thinkpads, and
possibly other systems, unusable with rfkill enabled.

Thank you,

Will Keaney


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]