* New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 @ 2017-05-13 12:19 Hans de Goede 2017-05-13 12:32 ` Hans de Goede 2017-05-13 12:35 ` Hans de Goede 0 siblings, 2 replies; 11+ messages in thread From: Hans de Goede @ 2017-05-13 12:19 UTC (permalink / raw) To: Arend van Spriel, Franky Lin, Hante Meuleman, Kalle Valo Cc: linux-wireless, brcm80211-dev-list.pdl Hi, I've just rebased my personal kernel tree to what will soon be 4.12-rc1 and I'm getting my dmesg log filled with the following errors: [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple of 8 [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple of 8 Other brcmfmac dmesg messages: [ 16.020013] brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Jul 17 2013 07:36:07 version 6.10.197.71 (r412987) FWID 01-882d2634 This is on a Asus T100TA which uses a 43241b1 Regards, Hans ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-13 12:19 New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 Hans de Goede @ 2017-05-13 12:32 ` Hans de Goede 2017-05-13 12:35 ` Hans de Goede 1 sibling, 0 replies; 11+ messages in thread From: Hans de Goede @ 2017-05-13 12:32 UTC (permalink / raw) To: Arend van Spriel, Franky Lin, Hante Meuleman, Kalle Valo Cc: linux-wireless, brcm80211-dev-list.pdl Hi, On 13-05-17 14:19, Hans de Goede wrote: > Hi, > > I've just rebased my personal kernel tree to what will soon be 4.12-rc1 > and I'm getting my dmesg log filled with the following errors: > > [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple of 8 > [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 > [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple of 8 > > Other brcmfmac dmesg messages: > > [ 16.020013] brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Jul 17 2013 07:36:07 version 6.10.197.71 (r412987) FWID 01-882d2634 > > This is on a Asus T100TA which uses a 43241b1 Ok, this seems to be a regression caused by: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e84ab604bded "brcmfmac: properly align buffers on certain platforms with 64 bit DMA" I believe this may need a different fix then that. Regards, Hans ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-13 12:19 New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 Hans de Goede 2017-05-13 12:32 ` Hans de Goede @ 2017-05-13 12:35 ` Hans de Goede 2017-05-13 13:39 ` Heiner Kallweit 1 sibling, 1 reply; 11+ messages in thread From: Hans de Goede @ 2017-05-13 12:35 UTC (permalink / raw) To: Arend van Spriel, Franky Lin, Hante Meuleman, Kalle Valo, Heiner Kallweit Cc: linux-wireless, brcm80211-dev-list.pdl <resend with the author of the commit causing this added> Hi, On 13-05-17 14:19, Hans de Goede wrote: > Hi, > > I've just rebased my personal kernel tree to what will soon be 4.12-rc1 > and I'm getting my dmesg log filled with the following errors: > > [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple of 8 > [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 > [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple of 8 > > Other brcmfmac dmesg messages: > > [ 16.020013] brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Jul 17 2013 07:36:07 version 6.10.197.71 (r412987) FWID 01-882d2634 > > This is on a Asus T100TA which uses a 43241b1 Ok, this seems to be a regression caused by: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e84ab604bded "brcmfmac: properly align buffers on certain platforms with 64 bit DMA" I believe this may need a different fix then that. Regards, Hans ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-13 12:35 ` Hans de Goede @ 2017-05-13 13:39 ` Heiner Kallweit 2017-05-13 14:55 ` Hans de Goede 0 siblings, 1 reply; 11+ messages in thread From: Heiner Kallweit @ 2017-05-13 13:39 UTC (permalink / raw) To: Hans de Goede, Arend van Spriel, Franky Lin, Hante Meuleman, Kalle Valo Cc: linux-wireless, brcm80211-dev-list.pdl Am 13.05.2017 um 14:35 schrieb Hans de Goede: > <resend with the author of the commit causing this added> > > Hi, > > On 13-05-17 14:19, Hans de Goede wrote: >> Hi, >> >> I've just rebased my personal kernel tree to what will soon be 4.12-rc1 >> and I'm getting my dmesg log filled with the following errors: >> >> [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple of 8 >> [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 >> [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple of 8 >> After a brief look at the code I'm not sure that the check actually checks for an error condition. Apart from the error messages: Do you face issues with the functionality of the driver? >> Other brcmfmac dmesg messages: >> >> [ 16.020013] brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Jul 17 2013 07:36:07 version 6.10.197.71 (r412987) FWID 01-882d2634 >> >> This is on a Asus T100TA which uses a 43241b1 > > Ok, this seems to be a regression caused by: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e84ab604bded > "brcmfmac: properly align buffers on certain platforms with 64 bit DMA" > > I believe this may need a different fix then that. > > Regards, > > Hans > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-13 13:39 ` Heiner Kallweit @ 2017-05-13 14:55 ` Hans de Goede 2017-05-14 8:21 ` Arend Van Spriel 0 siblings, 1 reply; 11+ messages in thread From: Hans de Goede @ 2017-05-13 14:55 UTC (permalink / raw) To: Heiner Kallweit, Arend van Spriel, Franky Lin, Hante Meuleman, Kalle Valo Cc: linux-wireless, brcm80211-dev-list.pdl Hi, On 13-05-17 15:39, Heiner Kallweit wrote: > Am 13.05.2017 um 14:35 schrieb Hans de Goede: >> <resend with the author of the commit causing this added> >> >> Hi, >> >> On 13-05-17 14:19, Hans de Goede wrote: >>> Hi, >>> >>> I've just rebased my personal kernel tree to what will soon be 4.12-rc1 >>> and I'm getting my dmesg log filled with the following errors: >>> >>> [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple of 8 >>> [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 >>> [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple of 8 >>> > After a brief look at the code I'm not sure that the check actually checks > for an error condition. Apart from the error messages: > Do you face issues with the functionality of the driver? Yes after a while I get -ETIMEOUT errors for any sdio transfers to the device. But I'm not sure if this is caused by this commit, I think I've seen this once with 4.11 too. I've reverted the commit for now, but I'm fine with instead of doing the revert dropping the error check if the brcmfmac developers think that is ok. Currently the ETIMEOUT seems to be gone, so if dropping the revert causes it to re-appear then we know more. Regards, Hans ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-13 14:55 ` Hans de Goede @ 2017-05-14 8:21 ` Arend Van Spriel 2017-05-14 11:45 ` Hans de Goede 0 siblings, 1 reply; 11+ messages in thread From: Arend Van Spriel @ 2017-05-14 8:21 UTC (permalink / raw) To: Hans de Goede, Heiner Kallweit, Franky Lin, Hante Meuleman, Kalle Valo Cc: linux-wireless, brcm80211-dev-list.pdl On 13-5-2017 16:55, Hans de Goede wrote: > Hi, > > On 13-05-17 15:39, Heiner Kallweit wrote: >> Am 13.05.2017 um 14:35 schrieb Hans de Goede: >>> <resend with the author of the commit causing this added> >>> >>> Hi, >>> >>> On 13-05-17 14:19, Hans de Goede wrote: >>>> Hi, >>>> >>>> I've just rebased my personal kernel tree to what will soon be 4.12-rc1 >>>> and I'm getting my dmesg log filled with the following errors: >>>> >>>> [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple >>>> of 8 >>>> [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 >>>> [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple >>>> of 8 >>>> >> After a brief look at the code I'm not sure that the check actually >> checks >> for an error condition. Apart from the error messages: >> Do you face issues with the functionality of the driver? > > Yes after a while I get -ETIMEOUT errors for any sdio transfers > to the device. But I'm not sure if this is caused by this commit, > I think I've seen this once with 4.11 too. > > I've reverted the commit for now, but I'm fine with instead of > doing the revert dropping the error check if the brcmfmac developers > think that is ok. Currently the ETIMEOUT seems to be gone, so > if dropping the revert causes it to re-appear then we know more. Instead of reverting please give this patch a try and let me know if it works for you. Regards, Arend --- diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/n index fc64b89..e034500 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -3422,7 +3422,7 @@ static int brcmf_sdio_bus_preinit(struct device *dev) /* otherwise, set txglomalign */ value = sdiodev->settings->bus.sdio.sd_sgentry_align; /* SDIO ADMA requires at least 32 bit alignment */ - value = max_t(u32, value, 4); + value = max_t(u32, value, ALIGNMENT); err = brcmf_iovar_data_set(dev, "bus:txglomalign", &value, sizeof(u32)); } ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-14 8:21 ` Arend Van Spriel @ 2017-05-14 11:45 ` Hans de Goede 2017-05-14 12:56 ` Arend Van Spriel 2017-05-19 18:03 ` Arend Van Spriel 0 siblings, 2 replies; 11+ messages in thread From: Hans de Goede @ 2017-05-14 11:45 UTC (permalink / raw) To: Arend Van Spriel, Heiner Kallweit, Franky Lin, Hante Meuleman, Kalle Valo Cc: linux-wireless, brcm80211-dev-list.pdl Hi, On 14-05-17 10:21, Arend Van Spriel wrote: > On 13-5-2017 16:55, Hans de Goede wrote: >> Hi, >> >> On 13-05-17 15:39, Heiner Kallweit wrote: >>> Am 13.05.2017 um 14:35 schrieb Hans de Goede: >>>> <resend with the author of the commit causing this added> >>>> >>>> Hi, >>>> >>>> On 13-05-17 14:19, Hans de Goede wrote: >>>>> Hi, >>>>> >>>>> I've just rebased my personal kernel tree to what will soon be 4.12-rc1 >>>>> and I'm getting my dmesg log filled with the following errors: >>>>> >>>>> [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple >>>>> of 8 >>>>> [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 >>>>> [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple >>>>> of 8 >>>>> >>> After a brief look at the code I'm not sure that the check actually >>> checks >>> for an error condition. Apart from the error messages: >>> Do you face issues with the functionality of the driver? >> >> Yes after a while I get -ETIMEOUT errors for any sdio transfers >> to the device. But I'm not sure if this is caused by this commit, >> I think I've seen this once with 4.11 too. >> >> I've reverted the commit for now, but I'm fine with instead of >> doing the revert dropping the error check if the brcmfmac developers >> think that is ok. Currently the ETIMEOUT seems to be gone, so >> if dropping the revert causes it to re-appear then we know more. > > Instead of reverting please give this patch a try and let me know if it > works for you. > > Regards, > Arend > --- > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > b/drivers/n > index fc64b89..e034500 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > @@ -3422,7 +3422,7 @@ static int brcmf_sdio_bus_preinit(struct device *dev) > /* otherwise, set txglomalign */ > value = sdiodev->settings->bus.sdio.sd_sgentry_align; > /* SDIO ADMA requires at least 32 bit alignment */ > - value = max_t(u32, value, 4); > + value = max_t(u32, value, ALIGNMENT); > err = brcmf_iovar_data_set(dev, "bus:txglomalign", &value, > sizeof(u32)); > } > I can confirm that the above fix fixes the messages. Regards, Hans ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-14 11:45 ` Hans de Goede @ 2017-05-14 12:56 ` Arend Van Spriel 2017-05-19 18:03 ` Arend Van Spriel 1 sibling, 0 replies; 11+ messages in thread From: Arend Van Spriel @ 2017-05-14 12:56 UTC (permalink / raw) To: Hans de Goede Cc: Heiner Kallweit, Franky Lin, Hante Meuleman, Kalle Valo, linux-wireless, open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER On Sun, May 14, 2017 at 1:45 PM, Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > > On 14-05-17 10:21, Arend Van Spriel wrote: >> >> On 13-5-2017 16:55, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 13-05-17 15:39, Heiner Kallweit wrote: >>>> >>>> Am 13.05.2017 um 14:35 schrieb Hans de Goede: >>>>> >>>>> <resend with the author of the commit causing this added> >>>>> >>>>> Hi, >>>>> >>>>> On 13-05-17 14:19, Hans de Goede wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I've just rebased my personal kernel tree to what will soon be >>>>>> 4.12-rc1 >>>>>> and I'm getting my dmesg log filled with the following errors: >>>>>> >>>>>> [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple >>>>>> of 8 >>>>>> [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of >>>>>> 8 >>>>>> [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple >>>>>> of 8 >>>>>> >>>> After a brief look at the code I'm not sure that the check actually >>>> checks >>>> for an error condition. Apart from the error messages: >>>> Do you face issues with the functionality of the driver? >>> >>> >>> Yes after a while I get -ETIMEOUT errors for any sdio transfers >>> to the device. But I'm not sure if this is caused by this commit, >>> I think I've seen this once with 4.11 too. >>> >>> I've reverted the commit for now, but I'm fine with instead of >>> doing the revert dropping the error check if the brcmfmac developers >>> think that is ok. Currently the ETIMEOUT seems to be gone, so >>> if dropping the revert causes it to re-appear then we know more. >> >> >> Instead of reverting please give this patch a try and let me know if it >> works for you. >> >> Regards, >> Arend >> --- >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> b/drivers/n >> index fc64b89..e034500 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> @@ -3422,7 +3422,7 @@ static int brcmf_sdio_bus_preinit(struct device >> *dev) >> /* otherwise, set txglomalign */ >> value = sdiodev->settings->bus.sdio.sd_sgentry_align; >> /* SDIO ADMA requires at least 32 bit alignment */ >> - value = max_t(u32, value, 4); >> + value = max_t(u32, value, ALIGNMENT); >> err = brcmf_iovar_data_set(dev, "bus:txglomalign", >> &value, >> sizeof(u32)); >> } >> > > I can confirm that the above fix fixes the messages. Thanks, Hans I will send out a patch with your Tested-by: Regards, Arend ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-14 11:45 ` Hans de Goede 2017-05-14 12:56 ` Arend Van Spriel @ 2017-05-19 18:03 ` Arend Van Spriel 2017-05-19 19:07 ` Heiner Kallweit 1 sibling, 1 reply; 11+ messages in thread From: Arend Van Spriel @ 2017-05-19 18:03 UTC (permalink / raw) To: Heiner Kallweit, Hante Meuleman Cc: Hans de Goede, Franky Lin, Kalle Valo, linux-wireless, brcm80211-dev-list.pdl On 14-5-2017 13:45, Hans de Goede wrote: > Hi, > > On 14-05-17 10:21, Arend Van Spriel wrote: >> On 13-5-2017 16:55, Hans de Goede wrote: >>> Hi, >>> >>> On 13-05-17 15:39, Heiner Kallweit wrote: >>>> Am 13.05.2017 um 14:35 schrieb Hans de Goede: >>>>> <resend with the author of the commit causing this added> >>>>> >>>>> Hi, >>>>> >>>>> On 13-05-17 14:19, Hans de Goede wrote: >>>>>> Hi, >>>>>> >>>>>> I've just rebased my personal kernel tree to what will soon be >>>>>> 4.12-rc1 >>>>>> and I'm getting my dmesg log filled with the following errors: >>>>>> >>>>>> [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple >>>>>> of 8 >>>>>> [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple >>>>>> of 8 >>>>>> [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple >>>>>> of 8 >>>>>> >>>> After a brief look at the code I'm not sure that the check actually >>>> checks >>>> for an error condition. Apart from the error messages: >>>> Do you face issues with the functionality of the driver? >>> >>> Yes after a while I get -ETIMEOUT errors for any sdio transfers >>> to the device. But I'm not sure if this is caused by this commit, >>> I think I've seen this once with 4.11 too. >>> >>> I've reverted the commit for now, but I'm fine with instead of >>> doing the revert dropping the error check if the brcmfmac developers >>> think that is ok. Currently the ETIMEOUT seems to be gone, so >>> if dropping the revert causes it to re-appear then we know more. >> >> Instead of reverting please give this patch a try and let me know if it >> works for you. >> >> Regards, >> Arend >> --- >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> b/drivers/n >> index fc64b89..e034500 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> @@ -3422,7 +3422,7 @@ static int brcmf_sdio_bus_preinit(struct device >> *dev) >> /* otherwise, set txglomalign */ >> value = sdiodev->settings->bus.sdio.sd_sgentry_align; >> /* SDIO ADMA requires at least 32 bit alignment */ >> - value = max_t(u32, value, 4); >> + value = max_t(u32, value, ALIGNMENT); >> err = brcmf_iovar_data_set(dev, "bus:txglomalign", >> &value, >> sizeof(u32)); >> } >> > > I can confirm that the above fix fixes the messages. Heiner, Could I get your ack or even better your test verdict as well? Regards, Arend ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-19 18:03 ` Arend Van Spriel @ 2017-05-19 19:07 ` Heiner Kallweit 2017-05-19 19:24 ` Arend Van Spriel 0 siblings, 1 reply; 11+ messages in thread From: Heiner Kallweit @ 2017-05-19 19:07 UTC (permalink / raw) To: Arend Van Spriel, Hante Meuleman, Helmut Klein Cc: Hans de Goede, Franky Lin, Kalle Valo, linux-wireless, brcm80211-dev-list.pdl Am 19.05.2017 um 20:03 schrieb Arend Van Spriel: > On 14-5-2017 13:45, Hans de Goede wrote: >> Hi, >> >> On 14-05-17 10:21, Arend Van Spriel wrote: >>> On 13-5-2017 16:55, Hans de Goede wrote: >>>> Hi, >>>> >>>> On 13-05-17 15:39, Heiner Kallweit wrote: >>>>> Am 13.05.2017 um 14:35 schrieb Hans de Goede: >>>>>> <resend with the author of the commit causing this added> >>>>>> >>>>>> Hi, >>>>>> >>>>>> On 13-05-17 14:19, Hans de Goede wrote: >>>>>>> Hi, >>>>>>> >>>>>>> I've just rebased my personal kernel tree to what will soon be >>>>>>> 4.12-rc1 >>>>>>> and I'm getting my dmesg log filled with the following errors: >>>>>>> >>>>>>> [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple >>>>>>> of 8 >>>>>>> [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple >>>>>>> of 8 >>>>>>> [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple >>>>>>> of 8 >>>>>>> >>>>> After a brief look at the code I'm not sure that the check actually >>>>> checks >>>>> for an error condition. Apart from the error messages: >>>>> Do you face issues with the functionality of the driver? >>>> >>>> Yes after a while I get -ETIMEOUT errors for any sdio transfers >>>> to the device. But I'm not sure if this is caused by this commit, >>>> I think I've seen this once with 4.11 too. >>>> >>>> I've reverted the commit for now, but I'm fine with instead of >>>> doing the revert dropping the error check if the brcmfmac developers >>>> think that is ok. Currently the ETIMEOUT seems to be gone, so >>>> if dropping the revert causes it to re-appear then we know more. >>> >>> Instead of reverting please give this patch a try and let me know if it >>> works for you. >>> >>> Regards, >>> Arend >>> --- >>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >>> b/drivers/n >>> index fc64b89..e034500 100644 >>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >>> @@ -3422,7 +3422,7 @@ static int brcmf_sdio_bus_preinit(struct device >>> *dev) >>> /* otherwise, set txglomalign */ >>> value = sdiodev->settings->bus.sdio.sd_sgentry_align; >>> /* SDIO ADMA requires at least 32 bit alignment */ >>> - value = max_t(u32, value, 4); >>> + value = max_t(u32, value, ALIGNMENT); >>> err = brcmf_iovar_data_set(dev, "bus:txglomalign", >>> &value, >>> sizeof(u32)); >>> } >>> >> >> I can confirm that the above fix fixes the messages. > > Heiner, > > Could I get your ack or even better your test verdict as well? > Unfortunately I don't have hardware to test this (as sdio isn't available on Odroid C2). However the patch looks logical and good to me. I add Helmut as he gave his Tested-by for commit 5ef1ecf060f28e "mmc: sdio: fix alignment issue in struct sdio_func". Maybe he can test your patch as well. Rgds, Heiner > Regards, > Arend > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 2017-05-19 19:07 ` Heiner Kallweit @ 2017-05-19 19:24 ` Arend Van Spriel 0 siblings, 0 replies; 11+ messages in thread From: Arend Van Spriel @ 2017-05-19 19:24 UTC (permalink / raw) To: Heiner Kallweit, Hante Meuleman, Helmut Klein Cc: Hans de Goede, Franky Lin, Kalle Valo, linux-wireless, brcm80211-dev-list.pdl On 19-5-2017 21:07, Heiner Kallweit wrote: > Am 19.05.2017 um 20:03 schrieb Arend Van Spriel: >> On 14-5-2017 13:45, Hans de Goede wrote: >>> Hi, >>> >>> On 14-05-17 10:21, Arend Van Spriel wrote: >>>> On 13-5-2017 16:55, Hans de Goede wrote: >>>>> Hi, >>>>> >>>>> On 13-05-17 15:39, Heiner Kallweit wrote: >>>>>> Am 13.05.2017 um 14:35 schrieb Hans de Goede: >>>>>>> <resend with the author of the commit causing this added> >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> On 13-05-17 14:19, Hans de Goede wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> I've just rebased my personal kernel tree to what will soon be >>>>>>>> 4.12-rc1 >>>>>>>> and I'm getting my dmesg log filled with the following errors: >>>>>>>> >>>>>>>> [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple >>>>>>>> of 8 >>>>>>>> [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple >>>>>>>> of 8 >>>>>>>> [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple >>>>>>>> of 8 >>>>>>>> >>>>>> After a brief look at the code I'm not sure that the check actually >>>>>> checks >>>>>> for an error condition. Apart from the error messages: >>>>>> Do you face issues with the functionality of the driver? >>>>> >>>>> Yes after a while I get -ETIMEOUT errors for any sdio transfers >>>>> to the device. But I'm not sure if this is caused by this commit, >>>>> I think I've seen this once with 4.11 too. >>>>> >>>>> I've reverted the commit for now, but I'm fine with instead of >>>>> doing the revert dropping the error check if the brcmfmac developers >>>>> think that is ok. Currently the ETIMEOUT seems to be gone, so >>>>> if dropping the revert causes it to re-appear then we know more. >>>> >>>> Instead of reverting please give this patch a try and let me know if it >>>> works for you. >>>> >>>> Regards, >>>> Arend >>>> --- >>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >>>> b/drivers/n >>>> index fc64b89..e034500 100644 >>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >>>> @@ -3422,7 +3422,7 @@ static int brcmf_sdio_bus_preinit(struct device >>>> *dev) >>>> /* otherwise, set txglomalign */ >>>> value = sdiodev->settings->bus.sdio.sd_sgentry_align; >>>> /* SDIO ADMA requires at least 32 bit alignment */ >>>> - value = max_t(u32, value, 4); >>>> + value = max_t(u32, value, ALIGNMENT); >>>> err = brcmf_iovar_data_set(dev, "bus:txglomalign", >>>> &value, >>>> sizeof(u32)); >>>> } >>>> >>> >>> I can confirm that the above fix fixes the messages. >> >> Heiner, >> >> Could I get your ack or even better your test verdict as well? >> > Unfortunately I don't have hardware to test this (as sdio isn't available > on Odroid C2). However the patch looks logical and good to me. > > I add Helmut as he gave his Tested-by for commit 5ef1ecf060f28e > "mmc: sdio: fix alignment issue in struct sdio_func". > Maybe he can test your patch as well. Ok. Thanks, Arend > Rgds, Heiner > >> Regards, >> Arend >> > ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-05-19 19:24 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-05-13 12:19 New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 Hans de Goede 2017-05-13 12:32 ` Hans de Goede 2017-05-13 12:35 ` Hans de Goede 2017-05-13 13:39 ` Heiner Kallweit 2017-05-13 14:55 ` Hans de Goede 2017-05-14 8:21 ` Arend Van Spriel 2017-05-14 11:45 ` Hans de Goede 2017-05-14 12:56 ` Arend Van Spriel 2017-05-19 18:03 ` Arend Van Spriel 2017-05-19 19:07 ` Heiner Kallweit 2017-05-19 19:24 ` Arend Van Spriel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox