* [PATCH] mt76: eeprom: tolerate corrected bit-flips
@ 2021-11-25 18:36 Daniel Golle
2021-11-25 18:44 ` Felix Fietkau
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Golle @ 2021-11-25 18:36 UTC (permalink / raw)
To: linux-mediatek, linux-wireless
Cc: Ryder Lee, Lorenzo Bianconi, Felix Fietkau, Hauke Mehrtens
mtd_read() returns -EUCLEAN in case of corrected bit-flips.
As data was read, don't error out in this case.
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
index 2d58aa31db934..0eb98f7ff7ec0 100644
--- a/drivers/net/wireless/mediatek/mt76/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
@@ -65,7 +65,7 @@ int mt76_get_of_eeprom(struct mt76_dev *dev, void *eep, int offset, int len)
offset = be32_to_cpup(list);
ret = mtd_read(mtd, offset, len, &retlen, eep);
put_mtd_device(mtd);
- if (ret) {
+ if (ret && !mtd_is_bitflip(err)) {
dev_err(dev->dev, "reading EEPROM from mtd %s failed: %i\n",
part, ret);
goto out_put_node;
--
2.34.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76: eeprom: tolerate corrected bit-flips
2021-11-25 18:36 [PATCH] mt76: eeprom: tolerate corrected bit-flips Daniel Golle
@ 2021-11-25 18:44 ` Felix Fietkau
2021-11-25 19:43 ` Daniel Golle
0 siblings, 1 reply; 3+ messages in thread
From: Felix Fietkau @ 2021-11-25 18:44 UTC (permalink / raw)
To: Daniel Golle, linux-mediatek, linux-wireless
Cc: Ryder Lee, Lorenzo Bianconi, Hauke Mehrtens
On 2021-11-25 19:36, Daniel Golle wrote:
> mtd_read() returns -EUCLEAN in case of corrected bit-flips.
> As data was read, don't error out in this case.
>
> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
> index 2d58aa31db934..0eb98f7ff7ec0 100644
> --- a/drivers/net/wireless/mediatek/mt76/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
> @@ -65,7 +65,7 @@ int mt76_get_of_eeprom(struct mt76_dev *dev, void *eep, int offset, int len)
> offset = be32_to_cpup(list);
> ret = mtd_read(mtd, offset, len, &retlen, eep);
> put_mtd_device(mtd);
> - if (ret) {
> + if (ret && !mtd_is_bitflip(err)) {
I don't think this will even compile (err vs ret)
- Felix
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76: eeprom: tolerate corrected bit-flips
2021-11-25 18:44 ` Felix Fietkau
@ 2021-11-25 19:43 ` Daniel Golle
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Golle @ 2021-11-25 19:43 UTC (permalink / raw)
To: Felix Fietkau
Cc: linux-mediatek, linux-wireless, Ryder Lee, Lorenzo Bianconi,
Hauke Mehrtens
On Thu, Nov 25, 2021 at 07:44:26PM +0100, Felix Fietkau wrote:
>
> On 2021-11-25 19:36, Daniel Golle wrote:
> > mtd_read() returns -EUCLEAN in case of corrected bit-flips.
> > As data was read, don't error out in this case.
> >
> > Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
> > index 2d58aa31db934..0eb98f7ff7ec0 100644
> > --- a/drivers/net/wireless/mediatek/mt76/eeprom.c
> > +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
> > @@ -65,7 +65,7 @@ int mt76_get_of_eeprom(struct mt76_dev *dev, void *eep, int offset, int len)
> > offset = be32_to_cpup(list);
> > ret = mtd_read(mtd, offset, len, &retlen, eep);
> > put_mtd_device(mtd);
> > - if (ret) {
> > + if (ret && !mtd_is_bitflip(err)) {
> I don't think this will even compile (err vs ret)
Oops, that has sneaked in when making use of the macro last minute.
I'll send v2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-25 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-25 18:36 [PATCH] mt76: eeprom: tolerate corrected bit-flips Daniel Golle
2021-11-25 18:44 ` Felix Fietkau
2021-11-25 19:43 ` Daniel Golle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox